v0.12.18 release proposal #10352
v0.12.18 release proposal #10352
Conversation
PR-URL: #9107 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #9191 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #9151 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #9150 Reviewed-By: João Reis <reis@janeasystems.com>
Refs: nodejs/Release#143 PR-URL: #9619 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
nodejs-github-bot
added
build
|
@rvagg The rationale behind the npm update was to pick up an updated license (nodejs/Release/issues/143) -- Does Node.js' |
|
yes it does @richardlau, thanks for that! I'll get it updated right now |
rvagg
force-pushed
the
v0.12.18-proposal
branch
from
845b6e4
to
ea10f97
Compare
|
updated main LICENSE with npm latest, inserted a new commit pointing to this PR, PTAL |
|
License update LGTM (at least to the naked eye (on a tablet atm so eyeballing is all I can do) the npm section matches npm's LICENSE). The changes to the main LICENSE are different to the changes to npm's LICENSE in #9619 but the content has ended up the same so I guess the main LICENSE wasn't kept in line with previous npm updates. |
|
there was another pr that came in recently targeting v0.12 I can't recall
which off the top of my head atm. will dig in first thing in the am est if
this release can wait.
…On Tue, Dec 20, 2016, 12:12 AM Richard Lau ***@***.***> wrote:
License update LGTM (at least to the naked eye (on a tablet atm so
eyeballing is all I can do) the npm section matches npm's LICENSE). The
changes to the main LICENSE are different to the changes to npm's LICENSE
in nodejs/node#9619 <#9619> but the
content has ended up the same so I guess the main LICENSE wasn't kept in
line with previous npm updates.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#10352 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV5NTL9rsuWQNFYDihyQfBVto_xIOks5rJ2O_gaJpZM4LRcw6>
.
|
|
@thealphanerd You might be thinking of #10261 (“tls: update builtin cert bundle for 0.12”)? |
|
#10261 (certs) was the one someone mentioned to me but it's closed, I agree with @sam-github's call on it, too disruptive at this late stage. I've closed out the other ones, they never became mergable. @richardlau the diff in LICENSE is there because changes were never rigorous there until recently. We have a tool to update it now on v4+ branches (tools/license-builder.sh) and although it's not automatic, it's mostly kept in sync with dependency licenses. |
rvagg
force-pushed
the
v0.12.18-proposal
branch
from
ea10f97
to
0bfa48e
Compare
Notable changes: * npm: upgrade from v2.15.1 to v2.15.11, including accurate updated license (Jeremiah Senkpiel) * process: `process.versions.ares` now outputs the c-ares version (Johan Bergström) PR-URL: #10352
|
tests all passing except for some flakys on Windows citgm looks OK, some expected failures (e.g. lodash not happy on 0.12 anymore apparently?), a minor ICU failure (capitalisation of a word!) but I'm assuming that's because we haven't updated ICU on 0.12 https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/488/ Releases are built and in staging waiting for promotion but @bnoordhuis flagged #10173 for possible inclusion and I'm not against that change, but don't want to hold on to this for days while that gets reviewed so if it's going to land it needs to be fairly quick. We're bumping up against Christmas and EOL here (yes, I should have opened this earlier! It was supposed to be done when we did the last v4 and v6 drops). |
|
@rvagg looks like @bnoordhuis also flagged #8027 for inclusion (EDIT: #10355) |
|
Also #10356 |
|
more context on the node_modules_version changes @ #7808, I'm not a fan of this change, it's unnecessary, particularly for a branch that's EOL, just hardwire your lookups for 0.10 and 0.12. I'm going to put a deadline on this and push out the release in ~12 hours from now. We're too close to Christmas and EOL already. I don't see anything compelling in the additions being pushed, even the |
Section 3.2 of the C++ standard states that destructor definitions implicitly "use" operator delete functions. Therefore, these operator delete functions must be defined even if they are never called by user code explicitly. http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261 gcc allows them to remain as empty definitions. However, not all compilers allow this. This pull request creates definitions which if ever called, result in an abort. PR-URL: #10356 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg
force-pushed
the
v0.12.18-proposal
branch
from
0bfa48e
to
7c27784
Compare
Notable changes: * npm: upgrade from v2.15.1 to v2.15.11, including accurate updated license (Jeremiah Senkpiel) * process: `process.versions.ares` now outputs the c-ares version (Johan Bergström) PR-URL: #10352
rvagg
force-pushed
the
v0.12.18-proposal
branch
from
7c27784
to
eb454c8
Compare
Notable changes: * npm: upgrade from v2.15.1 to v2.15.11, including accurate updated license (Jeremiah Senkpiel) * process: `process.versions.ares` now outputs the c-ares version (Johan Bergström) PR-URL: #10352
Notable changes:
* npm: upgrade from v2.15.1 to v2.15.11, including accurate updated
license (Jeremiah Senkpiel)
* process: `process.versions.ares` now outputs the c-ares version (Johan
Bergstrom)
PR-URL: nodejs/node#10352
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Notable changes:
* npm: upgrade from v2.15.1 to v2.15.11, including accurate updated
license (Jeremiah Senkpiel)
* process: `process.versions.ares` now outputs the c-ares version (Johan
Bergstrom)
PR-URL: nodejs/node#10352
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Notable changes: * npm: upgrade from v2.15.1 to v2.15.11, including accurate updated license (Jeremiah Senkpiel) * process: `process.versions.ares` now outputs the c-ares version (Johan Bergström) PR-URL: nodejs/node#10352
|
would this be a good candidate for a locked conversation…? |
@nodejs/collaborators this is almost certainly going to be the final v0.12.x release. If there's anything you think is missing speak up immediately.
Notable changes:
process.versions.aresnow outputs the c-ares version (Johan Bergström)Commits: