Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: reintroduce ares to versions #9191

Closed
wants to merge 1 commit into from
Closed

process: reintroduce ares to versions #9191

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Oct 19, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

process.versions.ares is missing in v0.12.17 (and earlier v0.12.x):

-bash-4.2$ ./node
> process.versions
{ http_parser: '2.3',
  node: '0.12.17',
  v8: '3.28.71.19',
  uv: '1.6.1',
  zlib: '1.2.8',
  modules: '14',
  openssl: '1.0.1u' }
> .exit
-bash-4.2$

Fixed by cherry-picking 01736dd (reference #347)

@jbergstroem @richardlau
process: reintroduce ares to versions
5ad6e17 
ares version info was accidentally removed in c80f8fa.

PR-URL: nodejs#347
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v0.12 labels Oct 19, 2016
@richardlau
Copy link
Member Author

Since I cherry-picked, the commit has the original commit message. Let me know if I should reword it.

cc @jbergstroem (since it was originally your fix 😄 )

@phillipj phillipj mentioned this pull request Oct 19, 2016
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Oct 19, 2016

Does this qualify as a change that should go into a maintenance branch?

@richardlau
Copy link
Member Author

Good question. It's there in v0.10.x, v4.x and later -- Just missing in v0.12.x. I'm guessing it doesn't affect anyone enough to have raised an issue about it.

@MylesBorins
Copy link
Contributor

we can out it in staging and include it in a future release if we need to
do one

On Wed, Oct 19, 2016, 9:22 PM Richard Lau notifications@github.com wrote:

Good question. It's there in v0.10.x, v4.x and later -- Just missing in
v0.12.x. I'm guessing it doesn't affect anyone enough to have raised an
issue about it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#9191 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV9M-GaL25B3vZ9EeNLRpAPs83aklks5q1nwCgaJpZM4KbYRN
.

@Fishrock123
Copy link
Contributor

Is this actually important to anyone?

@jbergstroem
Copy link
Member

@Fishrock123 consistency, perhaps.

@gibfahn
Copy link
Member

gibfahn commented Oct 20, 2016 •
edited
Loading

Change LGTM, no strong opinions on whether it needs to be added back in.

Is there any downside to including it in the next v0.12 release?

@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 20, 2016
jasnell pushed a commit that referenced this pull request Oct 28, 2016
@jbergstroem @jasnell
process: reintroduce ares to versions
0cdf344 
PR-URL: #9191
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Oct 28, 2016

Landed in v0.12-staging with 0cdf344

@jasnell jasnell closed this Oct 28, 2016
@rvagg rvagg mentioned this pull request Dec 20, 2016
Merged
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Dec 22, 2016
@jbergstroem @jBarz
process: reintroduce ares to versions
b9589d5 
PR-URL: nodejs/node#9191
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@richardlau @cjihrig @MylesBorins @Fishrock123 @jbergstroem @gibfahn @jasnell @nodejs-github-bot