test: mark dgram-multicast-multi-process as flaky on v0.12 #9150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI @ https://ci.nodejs.org/job/node-test-commit/5653/ with one dgram-multicast-multi-process failure in there that's flaky so we have a passing Windows! |
|
LGTM The test passes on my machine, the CI timeout is most likely a CI problem. I'll investigate. For now, marking as flaky is the right thing to do. |
|
Nit: If it's only flaky on Windows, maybe create a Windows-only section (with |
rvagg
added a commit
that referenced
this pull request
Oct 29, 2016
PR-URL: #9150 Reviewed-By: João Reis <reis@janeasystems.com>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 22, 2016
PR-URL: nodejs/node#9150 Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been consistently failing for a while now on some Windows setups, always making interpreting CI annoying.
Note this is v0.12!
/cc @nodejs/testing