-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix minor style issue in code examples #9482
Conversation
The commit message should include: |
Also, I think it might be more involved than just changing the one padding value. Changing the value also affects the Perhaps we could just keep the existing code {
padding: .1em .0em !important;
} or strip the |
I'll make sure I take a look at any existing issue next time. I'll add this. Thanks |
4d46d53
to
63c3f8a
Compare
Thanks, I've updated the PR with your solution. Let me know if there is anything I've missed. |
Erm, is there no way to do this without |
My CSS skills are definitely questionable so please let me know if you have something different in mind. I've updated the PR with the other suggestion provided by @mscdex. Having a separate |
I think the preferable solution would be to eliminate the /* TODO: eliminate the `pre > code` nesting in favor of `pre` */
pre > code {
padding: 0;
} But please make sure it doesn't affect anything else first :) |
@silverwind Thanks for your guidance. I've updated the PR and please let me know what you think. |
@@ -358,7 +360,6 @@ tt, code { | |||
color: #040404; | |||
background-color: #f2f2f2; | |||
border-radius: 2px; | |||
padding: .1em .3em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove this line, pre > code
wins over it in terms of rule specificity and this rule still necessary to add padding to inline <code>
blocks.
You can also drop the comment. See #9535 (comment) for my reasoning. |
I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: nodejs#9381
73fda06
to
bb57a57
Compare
Thanks! Landed in bd83422. |
I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: #9381 PR-URL: #9482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: #9381 PR-URL: #9482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: #9381 PR-URL: #9482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: #9381 PR-URL: #9482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: #9381 PR-URL: #9482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: #9381 PR-URL: #9482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
doc
Description of change
I've noticed that a few of the code examples have an minor indentation
issue with the first line, for example:
https://nodejs.org/api/child_process.html#child_process_child_process
This commit attempt to fix this issue by using the suggestion provided
by Brain White which is to add a separate style for code with a
padding-right and padding-left of .0em.
Fixes: #9381