doc: Add padding: 0 to pre > code

[hiendv]

Checklist

• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

[Trott]

LGTM if the @nodjes/Website folks (uh...there are 89 of them, so you know, not all of them, but at least a few) don't see a problem. I think there might be a competing fix for this already submitted, though. Anyone?

[Trott]

@nodejs/website

[danbev]

Thanks for doing this! We also have this PR open for this issue. I don't mind which PR gets merged just that we fix this :)

[hiendv]

@Trott @danbev Sorry, I couldn't find #9482 before. Should I close mine?

[silverwind]

Yeah, I'll close this in favor of #9482 which was first. I'm sorry and hope you find other areas to contribute.

[hiendv]

I see. Thank you, @silverwind. I was hoping mine will be merged since the previous PR is incomplete.

[silverwind]

I don't consider this change as the ideal solution as the <code> wrapping is unnecessary and ideally those block should just be <pre> only, with <code> being reserved for inline code blocks. That's why I requested a TODO comment.

If you like to take a look, the tool that generates the HTML lives here and you can run it through make doc-only.

[hiendv]

@silverwind Oh, I missed your TODO here: #9482 (comment)

So, does it mean the <code> is deprecated for fenced code blocks?
If my assumption is right, should I change the doc generation tool & the style also? I would happily look at this and make a PR if possible.

[silverwind]

I guess it's not as simple as I thought. The HTML5 spec recommends <pre><code></code></pre> for "a sample of computer code". While I don't particularily see a reason for it, I think it's best left as-is, so the solution here is likely proper.

[hiendv]

@silverwind pre > code may be more semantic, I guess. Anyway, thanks for your time and patience.