Tests: Refactored to es6 #9700
Closed
Tests: Refactored to es6 #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
requested changes
Nov 20, 2016
There was a problem hiding this comment.
Can you update the commit message according to https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit.
| assert.ifError(error); | ||
|
|
||
| var read = fs.createReadStream(emptyFile, { 'fd': fd }); | ||
| const read = fs.createReadStream(emptyFile, { 'fd': fd }); |
There was a problem hiding this comment.
Can you change { 'fd': fd } to just { fd }.
|
|
||
| read.once('data', function() { | ||
| read.once('data', () => { | ||
| throw new Error('data event should not emit'); |
There was a problem hiding this comment.
Can you replace the throws with common.fail().
|
Ok, thanks. Changes made. |
itsmed
force-pushed
the
strengthen-tests
branch
from
de2cb73 to
e20d3c7
Compare
jasnell
requested changes
Dec 5, 2016
| }); | ||
|
|
||
| read.once('end', common.mustCall(function endEvent1() {})); | ||
| }); | ||
|
|
||
| fs.open(emptyFile, 'r', function(error, fd) { | ||
| fs.open(emptyFile, 'r', (error, fd) => { |
There was a problem hiding this comment.
The callback here should be wrapped in a common.mustCall()
|
|
||
| fs.open(emptyFile, 'r', function(error, fd) { | ||
| fs.open(emptyFile, 'r', (error, fd) => { |
There was a problem hiding this comment.
The callback should be wrapped in a common.mustCall()
itsmed
force-pushed
the
strengthen-tests
branch
from
e20d3c7 to
0bfa619
Compare
|
Ok I think I've got it this time! |
italoacasas
approved these changes
Jan 16, 2017
jasnell
approved these changes
Jan 16, 2017
Changed var to const, assert.equal to assert.strictEqual
Replaced anonymous functions with arrow functions. Replaced throw new Error with common.fail.
Replaced anonymous functions with arrow functions. Replaced throw new Error with common.fail.
Changed var to const, assert.equal to assert.strictEqual
Replaced anonymous functions with arrow functions. Replaced throw new Error with common.fail.
itsmed
force-pushed
the
strengthen-tests
branch
from
0bfa619 to
6b3e7ef
Compare
|
@italoacasas rebase done. |
|
The previous CI job is gone. New CI: https://ci.nodejs.org/job/node-test-pull-request/6230/ |
fhinkel
approved these changes
Mar 26, 2017
fhinkel
pushed a commit
that referenced
this pull request
Mar 26, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: #9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: #9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: #9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: #9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: nodejs/node#9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Tests
Description of change
Changed var to const, assert.equal to assert.strictEqual. Changed anonymous functions to use arrow functions.