Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Refactored to es6 #9700

Closed
wants to merge 6 commits into from
+9 −6
Closed

Tests: Refactored to es6 #9700

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c701c13
Refactored to es6
itsmed Nov 19, 2016
54ccfa2
test: es6 update, replace throw with common.fail
itsmed Nov 20, 2016
9464b1d
test: es6 update, replace throw with common.fail
itsmed Nov 22, 2016
b2048bb
Refactored to es6
itsmed Nov 19, 2016
9baa222
test: es6 update, replace throw with common.fail
itsmed Nov 20, 2016
6b3e7ef
wrapped callbacks in common.mustCall
itsmed Dec 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions test/parallel/test-fs-empty-readStream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,32 +7,35 @@ const fs = require('fs');
const emptyFile = path.join(common.fixturesDir, 'empty.txt');

fs.open(emptyFile, 'r', common.mustCall((error, fd) => {

assert.ifError(error);

const read = fs.createReadStream(emptyFile, { 'fd': fd });
const read = fs.createReadStream(emptyFile, { fd });

read.once('data', () => {
throw new Error('data event should not emit');
common.fail('data event should not emit');
});

read.once('end', common.mustCall(function endEvent1() {}));
}));

fs.open(emptyFile, 'r', common.mustCall((error, fd) => {

assert.ifError(error);

const read = fs.createReadStream(emptyFile, { 'fd': fd });
const read = fs.createReadStream(emptyFile, { fd });

read.pause();

read.once('data', () => {
throw new Error('data event should not emit');
common.fail('data event should not emit');
});

read.once('end', function endEvent2() {
throw new Error('end event should not emit');
common.fail('end event should not emit');
});

setTimeout(common.mustCall(() => {
assert.strictEqual(read.isPaused(), true);
}), common.platformTimeout(50));
}, common.platformTimeout(50));
}));