Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Update readme with new process #37

Closed
wants to merge 10 commits into from
Closed

Update readme with new process #37

wants to merge 10 commits into from

Conversation

WaleedAshraf
Copy link
Contributor

@WaleedAshraf WaleedAshraf commented Jul 31, 2019

ping: @nodejs/community-committee

@RRomoff can you please go through the "Review Process for Original Posts" and "Review Process for Created Medium Posts" sections?
I think we can add more details and make it easier to understand but couldn't find time to do that.

We also need to to add a link for Trello.

closes nodejs/community-committee#439 nodejs/community-committee#491

@bnb bnb self-requested a review August 8, 2019 16:41
@WaleedAshraf WaleedAshraf requested a review from amiller-gh August 8, 2019 16:48
@WaleedAshraf
Copy link
Contributor Author

ping @nodejs/community-committee
Kindly review this.

Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested.

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Manil Chowdhury <manil.chowdhury@gmail.com>
@WaleedAshraf
Copy link
Contributor Author

Ping @nodejs/community-committee @amiller-gh @bnb
If possible, please review this before the meeting tomorrow.

@WaleedAshraf
Copy link
Contributor Author

ping @nodejs/community-committee, please review

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bnb
Copy link
Contributor

bnb commented Dec 26, 2019

FWIW I would like to review once the above changes are made. Currently just pending those changes.

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change. Otherwise I suppose this can ship.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM 👏🏽

@WaleedAshraf
Copy link
Contributor Author

@nodejs/community-committee
I have added

  • Editors
  • How to become an editor?
  • Benefits of being an editor
  • Current Editors

and removed the specific details about the submission process. There is still info available about the basic process and I think that is enough. We don't need to overdo it.
Let's discuss this in the next meeting.

README.md Show resolved Hide resolved
- You'll be added to [editors list on Medium](https://medium.com/the-node-js-collection/about).
- You'll receive discount to attend OpenJS Foundation Conference.

- Possibility to become a member of Node.js Project and avail benefits like [Travel Fund](https://github.com/nodejs/admin#travel-fund).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a benefit of being a member of the project.

If being an editor includes being a member of the project, this is inherently true and phrasing it like this is slightly misleading since it's something that comes inherently anyway rather than a specific benefit of this work.

If being an editor does not include being a member of the project, then this is also slightly misleading since there is additional work above and beyond being an editor that this requires.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being an editor will not include being project member. I think we should keep it nomination based. Like here.
Once we see, someone is actively reviewing posts for 2,3 months, we can nominate them to become part of Node.js Collection ( -> Community Committee -> Node.js Project).

I also don't want to overdo it in the start. Let's go with an easy and simple process, once we have enough editors, we can even put this on hold.

Point to mention Travel Fund here was that people know what benefits would they get in return. People who are not part of the project already, may not even know that there is a travel fund benefit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point to mention Travel Fund here was that people know what benefits would they get in return.

This is a good thing to include for the relevant groups. I do think it's important though to include it in the correct place, and, as you said, this is not something that people will get but something they could get if they stick around.

Once we see, someone is actively reviewing posts for 2,3 months, we can nominate them to become part of Node.js Collection ( -> Community Committee -> Node.js Project).

Is this documented anywhere? If so, I think that is the most appropriate place to include that context since it's the context in which it is accurate.

README.md Outdated Show resolved Hide resolved
@WaleedAshraf
Copy link
Contributor Author

@nodejs/community-committee It seems I would not be able to find time for this any soon. I'd be happy to help if someone else takes this from here.
Let's talk about this at the next meeting.

@WaleedAshraf
Copy link
Contributor Author

Closing in favor of #41

@WaleedAshraf WaleedAshraf deleted the readme branch August 6, 2020 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js Collection – Next Steps
6 participants