This repository has been archived by the owner on Aug 3, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Update readme with new process #37
Closed
Closed
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b20a2e5
updated process
WaleedAshraf 5ed7b8a
adding changes by rachel
WaleedAshraf c1f83be
Update wording.
WaleedAshraf f53b4ec
addressed comments / added ref for google doc
WaleedAshraf a6a493b
made process more simple / added list of current editors
WaleedAshraf f50c39a
fixed Resources link
WaleedAshraf 6f86ab7
fixed typo
WaleedAshraf d79324d
updated benefits and details to become reviewer
WaleedAshraf d64bf07
add email address in details
WaleedAshraf adf6d62
update editor details
WaleedAshraf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a benefit of being a member of the project.
If being an editor includes being a member of the project, this is inherently true and phrasing it like this is slightly misleading since it's something that comes inherently anyway rather than a specific benefit of this work.
If being an editor does not include being a member of the project, then this is also slightly misleading since there is additional work above and beyond being an editor that this requires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being an editor will not include being project member. I think we should keep it nomination based. Like here.
Once we see, someone is actively reviewing posts for 2,3 months, we can nominate them to become part of Node.js Collection ( -> Community Committee -> Node.js Project).
I also don't want to overdo it in the start. Let's go with an easy and simple process, once we have enough editors, we can even put this on hold.
Point to mention Travel Fund here was that people know what benefits would they get in return. People who are not part of the project already, may not even know that there is a travel fund benefit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good thing to include for the relevant groups. I do think it's important though to include it in the correct place, and, as you said, this is not something that people will get but something they could get if they stick around.
Is this documented anywhere? If so, I think that is the most appropriate place to include that context since it's the context in which it is accurate.