Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate Persian language into Doc #1844

Closed
wants to merge 3 commits into from
Closed

Conversation

armanatory
Copy link

No description provided.

Initiate Persian language with adding the 404 error page
@ghost
Copy link

ghost commented Oct 20, 2018

@armanatory
The build failed, I suggest you copying the en's structure with all of its files into the locale and do translations to your own language , don't forget to change the folder name to fa. And plz DO NOT translate anything in the blog folder under locale.

But still want to say "Thanks first for your contributions~"

@armanatory
Copy link
Author

@Maledong I did the same, and I'll do it again more precisely. Also appreciate your time and consideration.

@ghost ghost mentioned this pull request Oct 27, 2018
@ghost
Copy link

ghost commented Oct 27, 2018

@armanatory

No problem.

  1. I've checked your issue and it seems that because of your duplicated generated files by Visual Studio, Node cannot recognize these files, this cause your problem.

  2. Now I've started a new PR for your lang, so you can update your own local Persian language and based on this, you can do any changes carefully and continue your PRs (See the Persian PR at: fa: Create Nodejs Doc files in Persian #1866).

  3. Everytime when you do a submit, please DO NOT forget to run "npm run test" and then "npm run serve" to see the result (if there's something you haven't translated yet, this will be still directed to English).

Now this is the result when visiting in your local PC, you can have a view for that:http://localhost:8080/fa/

persian

@ghost ghost closed this Oct 27, 2018
ghost pushed a commit that referenced this pull request Oct 27, 2018
Create a new locale in Persian for more people speaking Persian and do contributions to that, based on the failure PR:#1844
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant