Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa: Create Nodejs Doc files in Persian #1866

Merged
1 commit merged into from Oct 27, 2018
Merged

fa: Create Nodejs Doc files in Persian #1866

1 commit merged into from Oct 27, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2018

Ref: #1844

Initiate Persian language with adding the 404 error page
@ghost ghost mentioned this pull request Oct 27, 2018
@AliSawari
Copy link

this could be helpful, as there is a growing up Persian-speaking community for Nodejs in Iran.
@fhemberger any plans on adding this?

@fhemberger
Copy link
Contributor

@AliSawari As far as I've seen, the pages are still all in English. A good starting point are the index.md and site.json files, from there you could gradually move on translating other parts.

I'd be happy to have a Persian version of the website as well to support the growing community.

@AliSawari
Copy link

@fhemberger thanks for the reply :)
I will share this in the community of developers for further translation. I'll take a look at the files and will add some more translations too.

@m-esm
Copy link
Contributor

m-esm commented Oct 27, 2018

@AliSawari count me in.

@ghost ghost merged commit 6733c04 into nodejs:master Oct 27, 2018
@ghost ghost deleted the addNewPersian branch October 27, 2018 23:19
@ghost
Copy link
Author

ghost commented Oct 27, 2018

@AliSawari & @m-esm & @armanatory:The page's index and site.json have both been in Persian. So I've submitted this PR and you all can continue your translations in Persian by forking and downloading, based on them.

For details when submitting, you can still see the last reply by me at top of this PR, now here's the actual look in index with site.json:

image

@m-esm
Copy link
Contributor

m-esm commented Oct 29, 2018

@Maledong what we can do about website direction ( RTL for Persian ) and the font? this 2 item caused poor UX for Persian users.

P.s. navigation menu items lead users to the English version

@fhemberger
Copy link
Contributor

fhemberger commented Oct 29, 2018

@anio
Copy link

anio commented Oct 29, 2018

About your P.S. @Maledong, you should set "locale" to "fa" in site.json.

@ghost
Copy link
Author

ghost commented Oct 30, 2018

@anio , @m-esm : Fixed and you can continue your contributions:)
image

@ghost
Copy link
Author

ghost commented Oct 31, 2018

@AliSawari & @m-esm & @armanatory,@anio:Your friends are waiting for you at https://github.com/orgs/nodejs/teams/nodejs-fa, please switch to "Members" and "Request to Join in". This is a translation group in Persian. You can cooperate together.

For more: https://help.github.com/articles/adding-organization-members-to-a-team/

@armanatory
Copy link

armanatory commented Oct 31, 2018

@Maledong With sincere thanks, I'm not a member of Nodejs organization. How could I do this?

@ghost
Copy link
Author

ghost commented Oct 31, 2018

@AliSawari & @m-esm & @armanatory

Hummm……, you need to write a request to be the collabrator of Nodejs, see this related and similar post: #1867. Perhaps you have to wait for a while because people are added batchly.

PS:This WON'T effect your contributions to the docs in Persian, you can still submit them and let others help to submit for you.

/cc:@fhemberger

@fhemberger
Copy link
Contributor

fhemberger commented Oct 31, 2018

Hummm……, you need to write a request to be the collabrator of Nodejs

No, you don't. You'll be added automatically once you contributed. But I can't add users myself, so we're doing this in batches and then pinging the Admins of the GitHub org to add you. Sorry it's that complicated. 🤷‍♂️

I was planning to do this shortly, so please just bear with me. 🙏

@fhemberger
Copy link
Contributor

Ref: #1872

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants