fa: translate locale Persian "fa" (#1866) #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhemberger
reviewed
Nov 1, 2018
| @@ -1,19 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Could you pease check if the translations here for site.json against those in #1871?
There was a problem hiding this comment.
Yes there are against #1871
reviews considered in the last commit and more parts translated.
There was a problem hiding this comment.
So we can merge this PR instead of #1871?
|
/cc @nodejs/nodejs-fa Please review the translation. Depending on the complexity of changes, a review of one or two people is recommended. If everything is okay, click "Approve". Then we know it's ready to be merged into master. |
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
|
LGTM with some nits |
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
ebraminio
reviewed
Nov 1, 2018
|
@m-esm @ebraminio Please let me know when you're done, everything is reviewed and you're good to merge. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
site.json and some of website main pages translated to Persian "fa" language.