Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display LTS and Stable on the frontpage #260

Closed
wants to merge 1 commit into from

Conversation

phillipj
Copy link
Member

Until v5.0.0 exists in https://nodejs.org/dist/index.json, only v4.x LTS will be displayed, in other words just as before besides some design changes:

lts screenshot

Will display two buttons side by side automagically, as soon as index.json contains a v5.0.0 release which is not marked as lts:

skjermbilde 2015-10-19 kl 10 52 47

Any thoughts?

Refs #200.

<a href="https://nodejs.org/dist/{{ project.currentVersion }}/" id="home-downloadbutton" data-version="{{ project.currentVersion }}" data-dl-local="{{ labels.download-for }}">{{ labels.download }}</a>
<h2 id="home-downloadhead" data-dl-local="{{ labels.download-for }}">{{ labels.download }}</h2>

<a href="https://nodejs.org/dist/{{ project.currentVersions.lts }}/" class="home-downloadbutton" title="Download {{ project.currentVersions.lts }} LTS" data-version="{{ project.currentVersions.lts }}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Texts need to be fully translatable, even "LTS" might need to be translated as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phillipj
Copy link
Member Author

Just too clarify, this can be merged now rather than syncing with the release of v5.0.0. It was made that way intentionally as I noticed @rvagg commented (somewhere?) that whenever a new release got promoted to http://nodejs.org/dist, it automatically kicked of a rebuild of the website.

@bnb
Copy link
Contributor

bnb commented Oct 19, 2015

+1, a solid job and indicates that LTS is important, too.

@phillipj
Copy link
Member Author

I think it would be valueable for us to track clicks on these links. Any chance I could access to the GA stats for nodejs.org @mikeal?

@jbergstroem
Copy link
Member

I'd like to see a simple explanation of LTS if we're to introduce both buttons. "What should I download"

@phillipj
Copy link
Member Author

@jbergstroem would a couple of keywords like shown in #200 comment suffice?

Will display two release lines on the frontpage,
as soon as https://nodejs.org/dist/index.json contains
a v5.0.0 release which is not marked as `lts`.

Until v5.0.0 exists in index.json, only v4.x LTS
will be displayed.
@phillipj
Copy link
Member Author

I'd like to see a simple explanation of LTS if we're to introduce both buttons. "What should I download"

In response to @jbergstroem and other similar comments in #200, I just pushed an update with @rvagg suggested taglines.

v4.2.1 only (before v5 exists)

skjermbilde 2015-10-28 kl 11 53 47

v4.2.1 and v5

skjermbilde 2015-10-28 kl 11 53 06

@phillipj phillipj mentioned this pull request Oct 28, 2015
1 task
@rvagg
Copy link
Member

rvagg commented Oct 28, 2015

+1 let's queue this up, aiming for a v5 release tomorrow, if that slips then next Monday or Tuesday at the latest

@fhemberger fhemberger mentioned this pull request Oct 29, 2015
@fhemberger fhemberger modified the milestone: 5.0.0 Oct 29, 2015
@fhemberger
Copy link
Contributor

Merged: e53ddb3.

I changed the wording from "Other LTS Downloads/Stable" to "Other Downloads: LTS/Stable".

@fhemberger fhemberger closed this Oct 29, 2015
@fhemberger fhemberger deleted the lts-n-stable-frontpage branch October 29, 2015 13:57
@phillipj
Copy link
Member Author

Nice @fhemberger 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants