Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0 release post #293

Merged
merged 4 commits into from
Oct 29, 2015
Merged

v5.0.0 release post #293

merged 4 commits into from
Oct 29, 2015

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 29, 2015

Binaries are in staging, aiming for a release at 3pm Pacific. Please review this post and let me know if you have any suggestions for changes or additions.

I guess we should ship the new LTS / Stable download button stuff around the same time, plus the ES6 updates? Who can be available to take care of that? I'd rather not have too much on my hands unless it's super-simple.

title: Node v5.0.0 (Stable)
slug: node-v5-0-0
layout: blog-post.hbs
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, author field not added, did you use an updated version of ./scripts/release-post.js?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

author shouldn't be strictly required.

@fhemberger
Copy link
Contributor

LGTM! 👍

@fhemberger
Copy link
Contributor

@rvagg @phillipj How about merging #260, #261 and #268 into the v5.0.0 branch instead of master? So when the release is ready, we just need to merge a single branch.

@fhemberger fhemberger modified the milestone: 5.0.0 Oct 29, 2015
@evanlucas
Copy link
Contributor

That seems like an ideal way to do it

@phillipj
Copy link
Member

Other than the missing author: Rod Vagg field it LGTM!

@fhemberger IMO LTS/Stable buttons in #260 and #261 could be merged ASAP. Both has been written with this in mind, too reduce big bang release of nodejs.org as soon as v5 gets released.

@fhemberger
Copy link
Contributor

Added ES6 updates here, changes for download page and index are already merged.

@rvagg rvagg force-pushed the v5.0.0 branch 2 times, most recently from 36b230c to f7891a4 Compare October 29, 2015 21:05
rvagg and others added 4 commits October 30, 2015 08:05
With node v5.0.0 will come an updated v8 that includes additional ES6
features. This adds some of those additional features to the ES6 doc
And updated some formatting of the content.
@rvagg
Copy link
Member Author

rvagg commented Oct 29, 2015

done, thanks folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants