Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add trailing slash to urls in previous releases table #6111

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

weslord
Copy link
Contributor

@weslord weslord commented Nov 11, 2023

Description

Add a trailing slash to the links to the "Release" links in the downloads table. The release URLs now return a 404 without them.

Related Issues

Fixes #6110

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@weslord weslord requested a review from a team as a code owner November 11, 2023 22:43
Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 10:45pm

@ljharb
Copy link
Member

ljharb commented Nov 11, 2023

Instead of this, could we make both URLs work?

@ovflowd
Copy link
Member

ovflowd commented Nov 11, 2023

@ljharb give a look on #6110 👀

@ovflowd
Copy link
Member

ovflowd commented Nov 12, 2023

Closing as superseded by nodejs/release-cloudflare-worker#63

@ovflowd ovflowd closed this Nov 12, 2023
@ovflowd
Copy link
Member

ovflowd commented Nov 12, 2023

Hmmm.. Actually I wonder if we should still merge this. Let's actually do this so the worker has less work to do.

Copy link

github-actions bot commented Nov 12, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 73 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 98 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/blog 🟢 93 🟢 97 🟢 92 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
79.34% (361/455) 64.81% (70/108) 63.04% (58/92)

Unit Test Report

Tests Skipped Failures Errors Time
54 0 💤 0 ❌ 0 🔥 5.166s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 15, 2023
Merged via the queue into nodejs:main with commit 450de11 Nov 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links to release downloads on Previous Releases page (missing trailing '/')
5 participants