fix: don't treat vX.X.X folders as files #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovflowd
approved these changes
Nov 11, 2023
| const fileExtension = path.substring(extensionDelimiter + 1); // +1 to remove the `.` | ||
|
|
||
| // `latest-vXX.x` directory | ||
| if (fileExtension.toLowerCase() === 'x') { |
There was a problem hiding this comment.
What if we check if it is a number or a string with more than two digits? I do not know of any valid file extension of just one digit, right?
There was a problem hiding this comment.
I think it should support any number of characters just because there are folders such as https://nodejs.org/download/release/v0.1.100/
There was a problem hiding this comment.
No what I meant is the following:
- Instead of checking against the file extension being "X" you check if it is one alphanumeric character or N digits number. Like it can be a number of any length but a string/character of 1 length.
It would even make sense to test with regex.
There was a problem hiding this comment.
Ahh I see, yeah I think that'd be a better way of doing this
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nodejs/nodejs.org#6110