Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

TODO: QuicSocketListener, QuicStreamListener and QuicSessionListener APIs #208

Closed
jasnell opened this issue Dec 2, 2019 · 2 comments
Closed

TODO: QuicSocketListener, QuicStreamListener and QuicSessionListener APIs #208

jasnell opened this issue Dec 2, 2019 · 2 comments
Assignees
@jasnell

Comments

@jasnell
Copy link
Member

jasnell commented Dec 2, 2019

Currently, the QuicSocket, QuicSession, and QuicStream objects directly call into the JavaScript side with MakeCallback. This limits the ability to use these objects from C++. Similarly to how StreamBase has a Listener interface that can be implemented at the C++ level, the various QUIC objects should also, allowing the classes to be used directly from the C++ side.
@jasnell jasnell self-assigned this Dec 2, 2019
@jasnell
Copy link
Member Author

jasnell commented Dec 2, 2019

(btw, I'm working on this :-) ...)

jasnell added a commit to jasnell/quic that referenced this issue Dec 3, 2019
@jasnell
quic: add QuicSocketListener
f29beef 
Fixes: nodejs#208
jasnell added a commit to jasnell/quic that referenced this issue Dec 3, 2019
@jasnell
quic: add QuicSessionListener
16932e3 
Fixes: nodejs#208
@jasnell
Copy link
Member Author

jasnell commented Dec 3, 2019

PR: #207

jasnell added a commit to jasnell/quic that referenced this issue Dec 4, 2019
@jasnell
quic: add QuicSocketListener
7a5810a 
Fixes: nodejs#208
jasnell added a commit to jasnell/quic that referenced this issue Dec 4, 2019
@jasnell
quic: add QuicSessionListener
f100945 
Fixes: nodejs#208
@jasnell jasnell closed this as completed in 8c8b1ce Dec 4, 2019
jasnell added a commit that referenced this issue Dec 4, 2019
@jasnell
quic: add QuicSessionListener
603f151 
Fixes: #208
PR-URL: #207
Reviewed-By: #207
addaleax pushed a commit that referenced this issue Dec 11, 2019
@jasnell @addaleax
quic: add QuicSocketListener
081a37f 
Fixes: #208
PR-URL: #207
Reviewed-By: #207
addaleax pushed a commit that referenced this issue Dec 11, 2019
@jasnell @addaleax
quic: add QuicSessionListener
bfc228e 
Fixes: #208
PR-URL: #207
Reviewed-By: #207
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jasnell jasnell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasnell