This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
quic: multiple refactors #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
use_ngtcp_path_storage
branch
2 times, most recently
from
a4536e2
to
16932e3
Compare
This was referenced Dec 3, 2019
jasnell
force-pushed
the
use_ngtcp_path_storage
branch
from
52d6086
to
57af916
Compare
addaleax
approved these changes
Dec 3, 2019
| @@ -98,6 +99,10 @@ class UDPWrapBase { | |||
| // Stores the sockaddr for the local socket in `name`. | |||
| virtual int GetSockName(sockaddr* name, int* namelen) = 0; | |||
|
|
|||
| virtual SocketAddress* GetPeerName(SocketAddress* addr = nullptr) = 0; | |||
|
|
|||
| virtual SocketAddress* GetSockName(SocketAddress* addr = nullptr) = 0; | |||
There was a problem hiding this comment.
This should be fine, but in the long run either the SocketAddress* variants or the sockaddr* variants should become non-virtual and implemented in terms of the other, I guess.
Also, could these maybe just return a SocketAddress instead of taking a pointer argument that doubles as the return value?
There was a problem hiding this comment.
+1 to the first part... will look at that in a future PR.
For the second part, I'll look at that but the current use of this in node_quic_socket.cc updates a member variable of QuicSocket...
udp_->GetSockName(&local_address_);The return value isn't actually used. I set it up this way just to give some flexibility that we may not actually need in the long run. That is, we could alternatively just drop the return value.
jasnell
force-pushed
the
use_ngtcp_path_storage
branch
from
eacc82c
to
58a1cd2
Compare
Allow for better future reuse of sockaddr related code by moving SocketAddress into it's own header
Allows monitoring the number of times packets have to be retransmitted because of loss or delayed ack. An implementation experiencing a high number of retransmits may need to be torn down or mitigated in some way. This allows the user code to keep track. Later, we may want to add a setting that enforces a maximum number of retransmissions before failing a connection. Fixes: nodejs#78
jasnell
force-pushed
the
use_ngtcp_path_storage
branch
from
89cad7e
to
04dd27d
Compare
jasnell
force-pushed
the
use_ngtcp_path_storage
branch
from
51968d1
to
85c628c
Compare
jasnell
added a commit
that referenced
this pull request
Dec 4, 2019
Allows monitoring the number of times packets have to be retransmitted because of loss or delayed ack. An implementation experiencing a high number of retransmits may need to be torn down or mitigated in some way. This allows the user code to keep track. Later, we may want to add a setting that enforces a maximum number of retransmissions before failing a connection. Fixes: #78 PR-URL: #207 Reviewed-By: #207
|
Landed |
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
Allows monitoring the number of times packets have to be retransmitted because of loss or delayed ack. An implementation experiencing a high number of retransmits may need to be torn down or mitigated in some way. This allows the user code to keep track. Later, we may want to add a setting that enforces a maximum number of retransmissions before failing a connection. Fixes: #78 PR-URL: #207 Reviewed-By: #207
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring and cleanup of utility bits and pieces.