When upgrading from 4.3.0 to 4.4.0, using esbuild --bundle to build will report an error Could not resolve "stream"

[leizongmin]

This is an example file test.js:

require('readable-stream');

Run the following commands (esbuild@0.17.12):

esbuild --bundle test.js

It outputs:

✘ [ERROR] Could not resolve "stream"

    node_modules/.pnpm/readable-stream@4.4.0/node_modules/readable-stream/lib/stream/promises.js:7:8:
      7 │ require('stream')
        ╵         ~~~~~~~~

  The package "stream" wasn't found on the file system but is built into node. Are you trying to
  bundle for node? You can use "--platform=node" to do that, which will remove this error.

1 error

If I use version 4.3.0, it will output correctly.

[kanongil]

This seems like another instance of the issue in #513, though this exposes it as a regression!

[leizongmin]

The problem was introduced from this commit b345071#diff-241fa22640048b6a147dec92f1ebf253043a1c4c342c7e52402112eb3c58f8fbR7

readable-stream/lib/stream/promises.js

Line 7 in b345071

require('stream')

I have another question: why require this module, but not use any properties or methods of stream?

[jeswr]

In order to avoid such regressions in the future can I suggest adding a test to this library which webpacks

import-all-test.js

import * as all from 'readable-stream'

using the config

webpack.config.js

const path = require("path");
module.exports = {
  mode: "development",
  entry: "./integration-tests/import-all-test.js",
  output: {
    path: path.resolve(__dirname, "integration-tests", "dist"),
    filename: "import-all-test.js",
  },
};

The test would just be running npm run test:build where that script is defined as "test:build": "webpack"

[mcollina]

Would you like to send a PR to fix this (adjust the build scripts) or just with the test?

[jeswr]

#517 should cover the main point - I will see if I can make that config more restrictive after the issue is patched.