fix: remove unused require('stream') and extend webpack tests
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
May 15, 2023
| @@ -4,7 +4,7 @@ const { ArrayPrototypePop, Promise } = require('../ours/primordials') | |||
| const { isIterable, isNodeStream, isWebStream } = require('../internal/streams/utils') | |||
| const { pipelineImpl: pl } = require('../internal/streams/pipeline') | |||
| const { finished } = require('../internal/streams/end-of-stream') | |||
| require('stream') | |||
There was a problem hiding this comment.
This needs to come from the build step, not modified here.
There was a problem hiding this comment.
Ah - didn't realise that the contents of lib/ were generated directly from the core nodejs codebase.
#520 should solve this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #516
Potentially supercedes #517 by also including a fix; which is removing
require('stream')in https://github.com/jeswr/readable-stream/blob/3caace80d34bacaeb3d2aa760f3bd0fbdd9ae3d3/lib/stream/promises.js.However this comment makes me suspicious of whether this one-liner is the desired fix - hence why I have opened this as a separate PR.