Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused require('stream') and extend webpack tests #519

Closed
wants to merge 6 commits into from

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented May 15, 2023

Closes #516

Potentially supercedes #517 by also including a fix; which is removing require('stream') in https://github.com/jeswr/readable-stream/blob/3caace80d34bacaeb3d2aa760f3bd0fbdd9ae3d3/lib/stream/promises.js.

However this comment makes me suspicious of whether this one-liner is the desired fix - hence why I have opened this as a separate PR.

@@ -4,7 +4,7 @@ const { ArrayPrototypePop, Promise } = require('../ours/primordials')
const { isIterable, isNodeStream, isWebStream } = require('../internal/streams/utils')
const { pipelineImpl: pl } = require('../internal/streams/pipeline')
const { finished } = require('../internal/streams/end-of-stream')
require('stream')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to come from the build step, not modified here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - didn't realise that the contents of lib/ were generated directly from the core nodejs codebase.

#520 should solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants