Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add airtap for continuous browser tests #340

Closed
wants to merge 10 commits into from
Closed

Add airtap for continuous browser tests #340

wants to merge 10 commits into from

Conversation

vweevers
Copy link
Contributor

@vweevers vweevers commented Jun 3, 2018

Made a few quick hacks to get most tests passing in local Chrome at least.

What's the concurrency limit of the Sauce Labs account? You may want to change Travis's concurrency setting depending on that.

vweevers
vweevers commented Jun 3, 2018
View reviewed changes
.airtap.yml Outdated
version: -3..latest
- name: firefox
version: -3..latest
# - name: safari
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if they are passing, let's go for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't know until you merge ;) I didn't run the tests on my own SL account or anything.

I'll uncomment safari and we'll see.

@vweevers vweevers mentioned this pull request Jun 3, 2018
Closed
@mcollina
Copy link
Member

mcollina commented Jun 3, 2018

What's the concurrency limit of the Sauce Labs account? You may want to change Travis's concurrency setting depending on that.

I would like to ask them to bump it, after this lands.

@mcollina
Copy link
Member

mcollina commented Jul 3, 2018

Can you please allow me to push to this branch? I've made some changes in the next branch, and I would like to push a rebase.

@mcollina
Copy link
Member

mcollina commented Jul 3, 2018 •
edited
Loading

I'm currently getting:

$ NODE_OPTIONS="--trace-warnings" npm run test-browsers

> readable-stream@3.0.0-dev0 test-browsers /Users/matteo/Repositories/readable-stream
> airtap --sauce-connect --loopback airtap.local --no-coverage test/browser.js

- testing: chrome @ Windows 10: 67
- queuing: <chrome 67 on Windows 10>
- restarting: <chrome 67 on Windows 10>
- restarting: <chrome 67 on Windows 10>
- restarting: <chrome 67 on Windows 10>
- restarting: <chrome 67 on Windows 10>
- restarting: <chrome 67 on Windows 10>
- restarting: <chrome 67 on Windows 10>
(node:72841) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 done listeners added. Use emitter.setMaxListeners() to increase limit
    at _addListener (events.js:280:19)
    at SauceBrowser.addListener (events.js:297:10)
    at SauceBrowser.once (events.js:341:8)
    at /Users/matteo/Repositories/readable-stream/node_modules/airtap/bin/airtap.js:271:21
    at next (/Users/matteo/Repositories/readable-stream/node_modules/batch/index.js:129:7)
    at Batch.end (/Users/matteo/Repositories/readable-stream/node_modules/batch/index.js:169:5)
    at shutdownAllBrowsers (/Users/matteo/Repositories/readable-stream/node_modules/airtap/bin/airtap.js:275:15)
    at Zuul.<anonymous> (/Users/matteo/Repositories/readable-stream/node_modules/airtap/bin/airtap.js:245:9)
    at emitOne (events.js:116:13)
    at Zuul.emit (events.js:211:7)

When running things locally. Then it's stuck there.

@vweevers
Copy link
Contributor Author

vweevers commented Jul 3, 2018

@ralphtheninja mind helping out with the airtap error above? I'm short on time

@mcollina
Copy link
Member

mcollina commented Jul 3, 2018

Also on Travis we are getting: "Skipping Airtap due to no secure Travis environment" Why is that happening?

@vweevers
Copy link
Contributor Author

vweevers commented Jul 3, 2018

@mcollina Travis secure environment variables are not available in PRs from external forks. Airtap doesn't run in this case because it would error (due to missing Sauce Labs credentials).

@mcollina
Copy link
Member

mcollina commented Jul 3, 2018

Oh ok. So I should really just test it locally and then push to a new branch.
Have you got any idea it does not work locally for me?

@vweevers
Copy link
Contributor Author

vweevers commented Jul 3, 2018 •
edited
Loading

Have you got any idea it does not work locally for me?

By locally do you mean in a local browser, or Sauce Labs? Because Airtap does not support the latter (yet), unless you manually run a Sauce Connect tunnel. See airtap/airtap#23

@vweevers vweevers mentioned this pull request Jul 3, 2018
Closed
@mcollina mcollina mentioned this pull request Jul 5, 2018
Merged
ralphtheninja
ralphtheninja reviewed Jul 5, 2018
View reviewed changes
package.json
@@ -24,6 +25,8 @@
"scripts": {
"test": "tap -j 4 test/parallel/*.js test/ours/*.js",
"ci": "TAP=1 tap test/parallel/*.js test/ours/*.js | tee test.tap",
"test-browsers": "airtap --sauce-connect -- test/browser.js",
"test-browser-local": "airtap --local --open -- test/browser.js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ralphtheninja
ralphtheninja reviewed Jul 5, 2018
View reviewed changes
.travis.yml Outdated
@@ -22,5 +22,5 @@ matrix:
script: npm run $CMD
env:
global:
- secure: nk/kDUZV385ey9kkrGi6EHvnslTAW+GEHGrjbFIsb8Foq01bL9oj0uPaVc5kaVWCHst3WsIdVMA1Hos/lN/WMHRyfOiSrVVWv0sVnzg0YaM9cBbn5jwXn30Z645REgQcoEDKrYFp8rE3RpPFgYDFWNh948qwPtwtnwNhoq/Gd9A=
- secure: faODkEUSlbH4fLBll4UkHeSEsCZdW+Hw+Sb6yDX5PXkIgq5wvqALIUgDIEBz2F8gciLlPlIssR2csKPqYIK5uwUq7uPBJVmwcf6i0K9NZaU/WaGaUVCzs2oMAoN007pTU30USEiWzfEGR+0d5hRKoeJdZIU0nBxkpLY4ZWM0SGU=
- secure: MMYiNZ8ICzNkz1OQ3/jFrcBVxG5eIGoUn1/IRL9JeWbB6gWg8kxAMFXZmLDJrJj5Zm6VD31mpX6PS3Ot46syMl+FnnyNCdqcCJUuUYCdRS8PanUnVq2QL1+9f2uT/S3UeQJhTaFXAzHA4cSNcaXlSB0QzbiDi0xZUobAAM/h5sw=
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina This worked, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it was skipped.

Skipping Airtap due to no secure Travis environment.

@vweevers vweevers closed this Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

@mcollina mcollina mcollina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vweevers @mcollina @ralphtheninja