Integrate airtap

[mcollina]

Supersedes #340 because of the elevated permission to run Sauce Labs with travis

[vweevers]

With latest airtap (0.0.9) you no longer need --no-coverage. Collecting code coverage became opt-in.

[mcollina]

I'm getting:

Error:
Airtap tried to run tests in Sauce Labs, however no credentials were provided.
See doc/cloud-testing.md for info on how to setup cloud testing.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! readable-stream@3.0.0-dev0 test-browsers: `airtap --sauce-connect -- test/browser.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the readable-stream@3.0.0-dev0 test-browsers script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-07-05T09_32_02_611Z-debug.log

have you got any clues? cc @vweevers @ralphtheninja

[ralphtheninja]

@mcollina These are different from 40bd7ad which worked?

[ralphtheninja]

Oh, you might need to escape the / there

[ralphtheninja]

From airtap:

} else if (!config.username || !config.key) {                                                                                                                                                                      
  console.error(chalk.red('Error:'))                                                                                                                                                                               
  console.error(chalk.red('Airtap tried to run tests in Sauce Labs, however no credentials were provided.'))                                                                                                       
  console.error(chalk.cyan('See doc/cloud-testing.md for info on how to setup cloud testing.'))                                                                                                                    
  process.exit(1)                                                                                                                                                                                                  
}

And username and key are set as:

config.username = process.env.SAUCE_USERNAME || config.sauce_username                                                                                                                                              
config.key = process.env.SAUCE_ACCESS_KEY || config.sauce_key                                                                                                                                                      

@mcollina To which environment variables are you setting the secure values?

[ralphtheninja]

@vweevers I'm on my way to Amsterdam and have to pack so don't have more time atm. Maybe you can jump in a bit?

[mcollina]

SAUCE_USERNAME and SAUCE_ACCESS_KEY.

But here is what I'm seeing on travis-ci.com:

https://travis-ci.com/nodejs/readable-stream/jobs/132925702#L430-L431

[vweevers]

Maybe try defining the vars in Travis instead?

[mcollina]

Setting in on travis worked!!!

[mcollina]

Works on IE 11 as well. Hurray!