Update to Node 18.0.0 #471
Conversation
lib/internal/primordials.js
Outdated
| @@ -0,0 +1,446 @@ | |||
|
|
|||
| 'use strict'; | |||
There was a problem hiding this comment.
remove this file, we don't want primordials.
There was a problem hiding this comment.
Unfortunately the Node core uses primordials everywhere.
I've replaced with a custom slimmed down primordials file.
|
This is great, awesome work - thanks 🙏 (Not LGTMing since I didn't review fully and Matteo is already looking whom I trust to approve once issues have been resolved) |
|
If supporting Node v12 does not add much of a problem, then it would be great! |
|
I'll try and see what happens. Will keep you posted! |
|
Good work! I see CI is passing.. minus Safari. Do you know why? |
|
There is a bug reported in airtap-sauce (airtap/sauce#11). I was thinking: since we can use playwright for all browsers and all platforms (thanks to GH actions matrix), do we still need sauce? Anyway, tomorrow I'll focus on Node 12 compatibility (I think I just have to transpile |
|
playwright would be awesome |
|
@mcollina I was able to accomplish both: Node 12 is now supported and SauceLabs has been dropped in favor of playwright. |
| }, | ||
| "license": "MIT" | ||
| "dependencies": { |
There was a problem hiding this comment.
I think this is missing the string_decoder module for Browser usage. Please verify everything is working webpack and rollup.
Summary:
object-inspect, which is for browsers, will be needed)streamAPI to Node 18.0.0.