Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 18.0.0 #471

Merged
merged 19 commits into from
May 23, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fixed node bundle on older versions.
ShogunPanda committed May 14, 2022
commit a6311365cd157c28919bfcf9d05784c3dffd9d1e
2 changes: 1 addition & 1 deletion lib/ours/index.js
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
const Stream = require('stream')

if (Stream && process.env.READABLE_STREAM === 'disable') {
const promises = require('stream/promises') // Explicit export naming is needed for ESM
const promises = Stream.promises // Explicit export naming is needed for ESM

module.exports._uint8ArrayToBuffer = Stream._uint8ArrayToBuffer
module.exports._isUint8Array = Stream._isUint8Array
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
const Stream = require('stream')

if (Stream && process.env.READABLE_STREAM === 'disable') {
const promises = require('stream/promises')
const promises = Stream.promises

// Explicit export naming is needed for ESM
module.exports._uint8ArrayToBuffer = Stream._uint8ArrayToBuffer
17 changes: 12 additions & 5 deletions src/test/browser/runner-node.mjs
Original file line number Diff line number Diff line change
@@ -62,9 +62,16 @@ function setupTape(configuration) {
})
}

const configuration = parseEnviroment()
setupTape(configuration)
async function main() {
const configuration = parseEnviroment()
setupTape(configuration)

// Execute the test suite
const __dirname = fileURLToPath(new URL('.', import.meta.url))
await import(`file://${resolve(__dirname, `../../tmp/${configuration.bundler}/suite.node.js`)}`)
// Execute the test suite
const __dirname = fileURLToPath(new URL('.', import.meta.url))
await import(`file://${resolve(__dirname, `../../tmp/${configuration.bundler}/suite.node.js`)}`)
}

main().catch((e) => {
console.error(e)
process.exit(1)
})
17 changes: 12 additions & 5 deletions test/browser/runner-node.mjs
Original file line number Diff line number Diff line change
@@ -62,9 +62,16 @@ function setupTape(configuration) {
})
}

const configuration = parseEnviroment()
setupTape(configuration)
async function main() {
const configuration = parseEnviroment()
setupTape(configuration)

// Execute the test suite
const __dirname = fileURLToPath(new URL('.', import.meta.url))
await import(`file://${resolve(__dirname, `../../tmp/${configuration.bundler}/suite.node.js`)}`)
// Execute the test suite
const __dirname = fileURLToPath(new URL('.', import.meta.url))
await import(`file://${resolve(__dirname, `../../tmp/${configuration.bundler}/suite.node.js`)}`)
}

main().catch((e) => {
console.error(e)
process.exit(1)
})