Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove FileReader #2728

Closed
wants to merge 375 commits into from
Closed

remove FileReader #2728

wants to merge 375 commits into from

Conversation

KhafraDev
Copy link
Member

No description provided.

@KhafraDev KhafraDev added the semver-major Features or fixes that will be included in the next semver major release label Feb 9, 2024
@KhafraDev
Copy link
Member Author

When we eventually drop support for node 18, we can finally get rid of our File implementation, which means we won't have to run any FileAPI WPTs anymore!

@mcollina
Copy link
Member

Unfortunately I don't think we can drop Node v18 anytime soon because it’ll be lts for another year.

@KhafraDev
Copy link
Member Author

Of course not 😅. I was just talking about way in the future. We still have our own File.

@ronag
Copy link
Member

ronag commented Feb 25, 2024

Rebase to next branch?

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@8a940ec). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2728   +/-   ##
=======================================
  Coverage        ?   88.44%           
=======================================
  Files           ?       81           
  Lines           ?     7384           
  Branches        ?        0           
=======================================
  Hits            ?     6531           
  Misses          ?      853           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KhafraDev
Copy link
Member Author

can we land this? 👀

@KhafraDev
Copy link
Member Author

I made a PR to remove FileReader from fetch tests. This is safe to land in the meantime. web-platform-tests/wpt#44893

Uzlopak
Uzlopak approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mertcanaltin and others added 19 commits March 14, 2024 11:54
@mertcanaltin @KhafraDev
fetch: improve output for FormData, Response, Request (nodejs#2955)
2e11fc8 
* fetch: improve output for FormData

* fetch: improve output for Response

* fetch: improve output for Request

* fetch: improve output for Request

* feat: repair code

* feat: repair code

* feat: repair code

* fix: repair codes & tests

* fix: repair tests & response & request class

* Update response.js

Co-authored-by: Khafra <maitken033380023@gmail.com>

* fix: test repair

---------

Co-authored-by: Mert Can Altin <mert.altin@trendyol.com>
Co-authored-by: Khafra <maitken033380023@gmail.com>
@tsctx
perf: optimize collectASequenceOfBytes (nodejs#2958)
4d59bf2
@mcollina
Bumped v6.9.0
3e59a2d 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@Uzlopak
test: fix flakyness of issue-803 test (nodejs#2960)
07019d0 
* test: improve performance of issue-803 test

* increase timeout
@KhafraDev
Cleanup format (nodejs#2959)
dcab693 
* for some reason this fixes the test

* cleanup custom format

* fixup
@mweberxyz
Chore: run tests daily against node nightly (nodejs#2969)
3be7ec9 
* chore(.github/workflows): factor out test running

* chore: add nightly tests

Closes nodejs#2932
@acommodari
fix: fix retry handler option (nodejs#2962)
9a56796
@dependabot
build(deps): bump node from 4999fa1 to 577f8eb in /build (nodejs#…
5d0cd38 
…2974)

Bumps node from `4999fa1` to `577f8eb`.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@metcoder95 @mcollina
feat(TS): add types for composed dispatchers (nodejs#2967)
a045e56 
* feat: add types for composed dispatchers

* Update types/dispatcher.d.ts

* refactor: adjust

---------

Co-authored-by: Matteo Collina <hello@matteocollina.com>
@metcoder95
fix: count for error response and network errors (nodejs#2966)
d4332fc 
* fix: count for error response and network errors

* test: add specific test for fix

* fix: conflict

* refactor: address feedback
@mcollina
Bumped v6.10.0
e434060 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
include strip-comments.js file for Node.js core
040cfcf 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
Bumepd v6.10.1
dd3918f 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
Do not fail test if streams support typed arrays (nodejs#2978)
2252a5f 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@Xvezda
fix(fetch): properly redirect non-ascii location header url (nodejs#2971
1b62571 
)

* fix(fetch): properly redirect non-ascii location header url

* chore: fix typo

* test: use simpler code

* chore: clarify what the code does

* chore: add comment

* chore: normalize location url only if it contains invalid character

* chore: apply suggestion

See: nodejs#2971 (comment)

* chore: remove redundant condition check
@peterver
perf: Remove double-stringify in setCookie (nodejs#2980)
fcbf6de 
* Remove double-stringify in setCookie

* Remove unnecessary semicolon
@clovis-guillemot
[fix nodejs#2982] use DispatcherInterceptor type for Dispatcher#Compo…
8fce214 
…se (nodejs#2983)
@MattBidewell @Uzlopak
fix: make EventSource properties enumerable (nodejs#2987)
bc304ff 
* make eventsource properties enumberable

* Use kEnumerableProperty for eventsource immutable fields

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
@benhalverson
docs: ✏️ fixed benchmark links (nodejs#2991)
83f36b7 
✅ Closes: nodejs#2988
DarkGL and others added 25 commits June 6, 2024 12:11
@DarkGL
perf: convert object to params (nodejs#3302)
250c863 
* Refactored passing object to function params

* Refactor write function argument order

* Updated argument order in writeBuffer function
@dependabot
build(deps-dev): bump borp from 0.14.0 to 0.15.0 (nodejs#3320)
be75e51 
Bumps [borp](https://github.com/mcollina/borp) from 0.14.0 to 0.15.0.
- [Release notes](https://github.com/mcollina/borp/releases)
- [Commits](https://github.com/mcollina/borp/commits/v0.15.0)

---
updated-dependencies:
- dependency-name: borp
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump c8 from 9.1.0 to 10.0.0 (nodejs#3321)
78a0c24 
Bumps [c8](https://github.com/bcoe/c8) from 9.1.0 to 10.0.0.
- [Release notes](https://github.com/bcoe/c8/releases)
- [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md)
- [Commits](bcoe/c8@v9.1.0...v10.0.0)

---
updated-dependencies:
- dependency-name: c8
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@maxbeatty
fix: add missing error classes to types (nodejs#3316)
f9997bb 
* add missing error classes to types

* test new types

* test error includes data with count when etag mismatch

* test content-range mismatch error

* remove test debugging
@jakecastelli
export interceptor to type def file (nodejs#3318)
1e508d7 
* export interceptor to type def file

Fixes: nodejs#3308

* fixup! add a test

* fixup! add retry, redirect, dump and remove createRedirectInterceptor

---------

Co-authored-by: jake li <jake.li@sine.co>
@dependabot
build(deps): bump node from e6d4495 to 075a5cc in /build (nodejs#…
9785b15 
…3326)

Bumps node from `e6d4495` to `075a5cc`.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jakecastelli
doc: clearify the behaviour of bodyTimeout in the request (nodejs#3324
7f54a24 
)
@tastypackets
feature: support pre-shared sessions (nodejs#3325)
39869b2 
Co-authored-by: Ezekiel Keator <ekeator@paypal.com>
@mcollina
Bumped v6.19.0
981fb3d 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@KhafraDev
don't append empty origin (nodejs#3335)
1573f69
@github-actions
Bumped v6.19.1 (nodejs#3336)
f6b9b44 
Co-authored-by: github-actions <github-actions@github.com>
@KhafraDev
fix nodejs#3337 (nodejs#3338)
035524e 
* fix nodejs#3337

* fixup
@jazelly
build: use husky as husky install is deprecated (nodejs#3340)
5dadb95
@Uzlopak
fix: interceptors.d.ts has no default export (nodejs#3332)
a7441d8 
* fix: types interceptors default export

* test for bugs in typescript
@github-actions
Bumped v6.19.2 (nodejs#3342)
532b7b2 
Co-authored-by: github-actions <github-actions@github.com>
@tsctx
fetch: fix content-encoding order (nodejs#3343)
e5c242d
@mcollina
Add regression test for broken body (nodejs#3346)
9134ee6 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@dependabot
build(deps): bump node from 075a5cc to 9af472b in /build (nodejs#…
ce240da 
…3355)

Bumps node from `075a5cc` to `9af472b`.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Gigioliva
fix: post request signal (nodejs#3354)
a5eac88
@ronag
Revert "fix: post request signal (nodejs#3354)" (nodejs#3359)
02c3a67
@tsctx
websocket: don't use pooled buffer in mask pool (nodejs#3357)
27b2589 
* websocket: don't use pooled buffer in mask pool

* add test

* fixup

* fixup
@ronag
fix: consider bytes read when dumping (nodejs#3360)
0455e06
@ronag
refactor: simplify signal handling (nodejs#3362)
3f4ef9a
@ronag
fix: use explicit flag for when use has interacted with stream (nodej…
59fc6d5 
…s#3361)
@DarkGL
Refactor example documentation structure and add CacheableLookup exam…
dd98299 
…ple (nodejs#3363)
@KhafraDev KhafraDev mentioned this pull request Jun 24, 2024
Closed
13 tasks
@KhafraDev KhafraDev force-pushed the remove-filereader branch 2 times, most recently from 3723521 to dd98299 Compare June 24, 2024 19:15
@KhafraDev KhafraDev closed this Jun 24, 2024
@KhafraDev KhafraDev deleted the remove-filereader branch September 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
semver-major Features or fixes that will be included in the next semver major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.