refactor: removed unecessary statement #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
commented
May 3, 2020
| function reconnect (client, err) { | ||
| err = err || new Error('premature close') |
There was a problem hiding this comment.
|
flaky test again, will look into why it's flaky |
|
merged into #45 |
metcoder95
pushed a commit
to mkaufmaner/undici
that referenced
this pull request
Jun 21, 2023
* chore: add http2 alpn test using fastify * chore: update to test https 1 with http2 * chore: update alpn test to return server request alpn protocol and http version * chore: add alpn with body * fix: remove fastify from package json
mkaufmaner
added a commit
to mkaufmaner/undici
that referenced
this pull request
Jul 7, 2023
* chore: add http2 alpn test using fastify * chore: update to test https 1 with http2 * chore: update alpn test to return server request alpn protocol and http version * chore: add alpn with body * fix: remove fastify from package json
mcollina
added a commit
that referenced
this pull request
Sep 8, 2023
* feat: port H2 work with latest main * fix: linting errors * refactor: adjust support for headers and set testing * test: add testing for h2 * refactor: make http2 session handle shorter * feat: add support for sending body over http2 * feat: ensure support for streams over H2 * refactor: remove noisy logs * feat: support 100 continue * feat: support for iterators * feat: add support for Blobs * refactor: adapt contracts to h2 support * refactor: cleanup * feat: support for content-length * refactor: body write * test: refactor check continue test * fix: bad check for headers * fix: bad change * chore: add http2 alpn test (#34) * chore: add http2 alpn test using fastify * chore: update to test https 1 with http2 * chore: update alpn test to return server request alpn protocol and http version * chore: add alpn with body * fix: remove fastify from package json * refactor: remove leftover * test: ensure dispatch feature * feat(h2): support connect * fix: pass signal down the road * test: ensure stream works as expected * test: ensure pipeline works as expected * test: ensure upgrade fails * test: ensure destroy works as expected * feat: allow to disable H2 calls upon request * fix: linting * feat: support GOAWAY frame (server-side) * refactor; use h2 constants * feat: initial shape of concurrent stream handling * refactor: header processing * chore: http/2 benchmark (#35) Co-authored-by: Carlos Fuentes <me@metcoder.dev> * refactor: adjust accordingly to review * fix: add missing error handler for socket * refactor: headers handling * feat: initial concurrent stream support * fix: lint * refactor: adjust several pieces * fix: support h2 headers for fetch * feat: enhance h2 for fetch * refactor: apply review suggestions Co-authored-by: Robert Nagy <ronagy@icloud.com> * refactor: set allowh2 to false * fix: linting * refactor: implement kHTTPConnVersion symbol * test: adjust testing * feat: buil factory * fix: rebase * feat: enhance TS types for maxConcurrent streams * test: move fetch tests to fetch folder * feat: add experimental warning * test: refactor suite * refactor: apply several changes * test: split tests between v20 and lower --------- Co-authored-by: Michael Kaufman <2073135+mkaufmaner@users.noreply.github.com> Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Matteo Collina <hello@matteocollina.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* feat: port H2 work with latest main * fix: linting errors * refactor: adjust support for headers and set testing * test: add testing for h2 * refactor: make http2 session handle shorter * feat: add support for sending body over http2 * feat: ensure support for streams over H2 * refactor: remove noisy logs * feat: support 100 continue * feat: support for iterators * feat: add support for Blobs * refactor: adapt contracts to h2 support * refactor: cleanup * feat: support for content-length * refactor: body write * test: refactor check continue test * fix: bad check for headers * fix: bad change * chore: add http2 alpn test (nodejs#34) * chore: add http2 alpn test using fastify * chore: update to test https 1 with http2 * chore: update alpn test to return server request alpn protocol and http version * chore: add alpn with body * fix: remove fastify from package json * refactor: remove leftover * test: ensure dispatch feature * feat(h2): support connect * fix: pass signal down the road * test: ensure stream works as expected * test: ensure pipeline works as expected * test: ensure upgrade fails * test: ensure destroy works as expected * feat: allow to disable H2 calls upon request * fix: linting * feat: support GOAWAY frame (server-side) * refactor; use h2 constants * feat: initial shape of concurrent stream handling * refactor: header processing * chore: http/2 benchmark (nodejs#35) Co-authored-by: Carlos Fuentes <me@metcoder.dev> * refactor: adjust accordingly to review * fix: add missing error handler for socket * refactor: headers handling * feat: initial concurrent stream support * fix: lint * refactor: adjust several pieces * fix: support h2 headers for fetch * feat: enhance h2 for fetch * refactor: apply review suggestions Co-authored-by: Robert Nagy <ronagy@icloud.com> * refactor: set allowh2 to false * fix: linting * refactor: implement kHTTPConnVersion symbol * test: adjust testing * feat: buil factory * fix: rebase * feat: enhance TS types for maxConcurrent streams * test: move fetch tests to fetch folder * feat: add experimental warning * test: refactor suite * refactor: apply several changes * test: split tests between v20 and lower --------- Co-authored-by: Michael Kaufman <2073135+mkaufmaner@users.noreply.github.com> Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Matteo Collina <hello@matteocollina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup