Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removed unecessary statement #34

Closed
wants to merge 2 commits into from
Closed

refactor: removed unecessary statement #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35a3c6f
refactor: removed unecessary statement
ronag May 3, 2020
0b2c70c
Merge branch 'master' into cleanup
ronag May 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,20 +51,7 @@ function connect (client) {
})
}

function destroyMaybe (client) {
if (
client.closed &&
!client[kLastBody] &&
client[kQueue].length() === 0 &&
client[kInflight].length === 0
) {
client.destroy()
}
}

function reconnect (client, err) {
err = err || new Error('premature close')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err can never be falsy, https://github.com/mcollina/undici/pull/34/files#diff-50cfa59973c04321b5da0c6da0fdf4feL49


if (client[kLastBody]) {
client[kLastBody].destroy(err)
client[kLastBody] = null
Expand Down Expand Up @@ -427,6 +414,17 @@ function parseHeaders (headers) {

module.exports = Client

function destroyMaybe (client) {
if (
client.closed &&
!client._lastBody &&
client[kQueue].length() === 0 &&
client[kCallbacks].length === 0
) {
client.destroy()
}
}

function destroySocket (socket, err, cb) {
// This code is basically the same as...
// stream.finished(socket, er => cb(err || er))
Expand Down