-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support request cache control directives #3658
feat: support request cache control directives #3658
Conversation
3ebfdd8
to
9a15ece
Compare
9a15ece
to
a0b52e3
Compare
a0b52e3
to
d034c54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
13fe5e0
to
4c3dd04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cc @ronag PTAL |
Co-authored-by: Robert Nagy <ronagy@icloud.com> Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
6ca427c
to
799d7ea
Compare
@metcoder95 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Note: this is a draft since #3562 isn't landed. Until it is landed, this will be based off of that pr's branch. For the actual diff see flakey5/undici@flakey5/3231...flakey5:undici:flakey5/20240924/cli-cache-controlThis relates to...
Adding client side http caching (#3562)
Rationale
Changes
Features
RFC9111 allows the request to specify a cache-control header with directives that can affect how we handle the request in the cache interceptor (re 5.2.1). This adds support for them.
Bug Fixes
Breaking Changes and Deprecations
Status
cc @mcollina @ronag