Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3736): leaked error event on response body #3740

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix(#3736): leaked error event on response body #3740

merged 2 commits into from
Oct 16, 2024

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Oct 16, 2024

This relates to...

Closes #3736

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95 metcoder95 merged commit 8e025d1 into main Oct 16, 2024
40 checks passed
Copy link
Contributor

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3740-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8e025d1cf5a453ff158cb1bd40ff6929e1b27bb1
# Push it to GitHub
git push --set-upstream origin backport-3740-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3740-to-v6.x.

@metcoder95 metcoder95 deleted the fix/3736 branch October 16, 2024 18:24
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to catch AbortError from undici.request after server returns
4 participants