-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#3736): back-port 183f8e9 to v6.x #3855
Conversation
Test failures seem limited to Node 22 and TLS behaviour, not the substance of the PR:
|
OK I found #3769 which addresses a change change in error messages in Node v22. I backported the fix and hope tests now pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should have an error handler registered...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I agree with this but it seems I approved the other one...
This relates to...
This applies the changes in #3740 that failed automatic backport into
v6.x
. Our testing suggests that this resolves #3848.Rationale
Changes
Adds a no-op
"error"
event handler to theres
stream when handlingAbortSignal
aborts inrequest()
that was otherwise leading to process-level uncaught exceptions in our codebase.Features
N/A
Bug Fixes
Fixes #3736 in v6.x
Fixes #3848 in v6.x
Breaking Changes and Deprecations
Status
test/issue-3356.js
times out with this change undernpm test
but not if run directly vianode test/issue-3356.js
.