fix(#3736): back-port 183f8e9 to v6.x #3855
Merged
+45
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
This applies the changes in #3740 that failed automatic backport into
v6.x
. Our testing suggests that this resolves #3848.Rationale
Changes
Adds a no-op
"error"
event handler to theres
stream when handlingAbortSignal
aborts inrequest()
that was otherwise leading to process-level uncaught exceptions in our codebase.Features
N/A
Bug Fixes
Fixes #3736 in v6.x
Fixes #3848 in v6.x
Breaking Changes and Deprecations
Status
test/issue-3356.js
times out with this change undernpm test
but not if run directly vianode test/issue-3356.js
.