This repository has been archived by the owner on Mar 25, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
SmartOS cannot build on master #1
Comments
Looking at it. |
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…1 of https://codereview.chromium.org/2265903002/ ) Reason for revert: found the culprit Original issue's description: > Add debug code to catch faulty interceptor > > BUG=chromium:625155 > R=jkummerow@chromium.org > > Committed: https://crrev.com/d181e6e1e6f95ee9c8005a2ad0fc846142dc8aad > Cr-Commit-Position: refs/heads/master@{#38775} TBR=jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:625155 Review-Url: https://codereview.chromium.org/2282663002 Cr-Commit-Position: refs/heads/master@{#38929}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…codereview.chromium.org/2278653003/ ) Reason for revert: Tanks pretty much alle metrics across the board. Probably LO space limit too low but needs investigation. Original issue's description: > [heap] Switch to 500k pages > > Decrease regular heap object size to 400k. In a follow up, we can now get rid of > the new space border page while keeping the 1M minimum new space size. > > This reverts commit 1617043. > > BUG=chromium:636331 > > Committed: https://crrev.com/2101e691caeef656eb91f1c98620b3955d337c83 > Cr-Commit-Position: refs/heads/master@{#38916} TBR=ulan@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:636331 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2289493002 Cr-Commit-Position: refs/heads/master@{#38960}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…:1 of https://codereview.chromium.org/2264283007/ ) Reason for revert: Speculative revert because of roll blocker https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/2241 Original issue's description: > Fix compiler warnings on "make android_arm" > > Committed: https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6 > Cr-Commit-Position: refs/heads/master@{#38937} TBR=bmeurer@chromium.org,jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2286163002 Cr-Commit-Position: refs/heads/master@{#38961}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…:1 of https://codereview.chromium.org/2286163002/ ) Reason for revert: Roll was unstuck before the revert landed => reland Original issue's description: > Revert of Fix compiler warnings on "make android_arm" (patchset #1 id:1 of https://codereview.chromium.org/2264283007/ ) > > Reason for revert: > Speculative revert because of roll blocker https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/2241 > > Original issue's description: > > Fix compiler warnings on "make android_arm" > > > > Committed: https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6 > > Cr-Commit-Position: refs/heads/master@{#38937} > > TBR=bmeurer@chromium.org,jkummerow@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Committed: https://crrev.com/d992c1f52f116930239ed90cc033442047e789b4 > Cr-Commit-Position: refs/heads/master@{#38961} TBR=bmeurer@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2285113002 Cr-Commit-Position: refs/heads/master@{#38962}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…omium.org/2289063002/ ) Reason for revert: Breaks tsan build generation: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11441 Original issue's description: > Update V8 DEPS. > > Rolling v8/build to 52f474cdb9e67007b938fd4a47220cb3c012e5e8 > > Rolling v8/third_party/WebKit/Source/platform/inspector_protocol to 84d90b2cc3f01a39bf73a8119a5cec0337d00c9f > > Rolling v8/tools/clang to 3e1948978834c16073c1b076410df1a80adda1f5 > > Rolling v8/tools/mb to ac239cc82ef08858d6f2b75216dd13afcdbc6ac3 > > TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org > > Committed: https://crrev.com/3b8a2e5129fec64674bb0191cba5aa4592d08d5f > Cr-Commit-Position: refs/heads/master@{#38995} TBR=hablich@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2290163002 Cr-Commit-Position: refs/heads/master@{#38998}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…tchset #1 id:1 of https://codereview.chromium.org/2297523002/ ) Reason for revert: Seems to break webkit unit tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/9360 https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/5503 Original issue's description: > Release streamed script resources after it was compiled > > Otherwise, we'd hold on to the resources until the embedder frees them > which might take a long time > > R=marja@chromium.org,verwaest@chromium.org > BUG= > > Committed: https://crrev.com/877dac34465c018bb534b7781fbe242ae4e33c32 > Cr-Commit-Position: refs/heads/master@{#38999} TBR=marja@chromium.org,verwaest@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2290173003 Cr-Commit-Position: refs/heads/master@{#39012}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
Using --trace-wasm-decoder prints unknowns for prefix opcodes, example: @3 #1:Block | env = 0x5547c10, state = R, reason = block:start, control = #0:Start @4 v8#14:GetLocal | i@4:GetLocal[0] @6 #e5:Unknown | s@6:Unknown @8 v8#15:SetLocal | s@8:SetLocal[1] @10 v8#14:GetLocal | s@8:SetLocal[1] i@10:GetLocal[0] @12 v8#14:GetLocal | s@8:SetLocal[1] i@10:GetLocal[0] s@12:GetLocal[1] @14 #cb:I8Const | s@8:SetLocal[1] i@10:GetLocal[0] s@12:GetLocal[1] i@14:I8Const @16 #e5:Unknown | s@8:SetLocal[1] i@10:GetLocal[0] i@16:Unknown Fixed to print: @3 #1:Block | env = 0x45cac10, state = R, reason = block:start, control = #0:Start @4 v8#14:GetLocal | i@4:GetLocal[0] @6 #e5 #1b:I32x4Splat | s@6:I32x4Splat @8 v8#15:SetLocal | s@8:SetLocal[1] @10 v8#14:GetLocal | s@8:SetLocal[1] i@10:GetLocal[0] @12 v8#14:GetLocal | s@8:SetLocal[1] i@10:GetLocal[0] s@12:GetLocal[1] @14 #cb:I8Const | s@8:SetLocal[1] i@10:GetLocal[0] s@12:GetLocal[1] i@14:I8Const @16 #e5 #1c:I32x4ExtractLane | s@8:SetLocal[1] i@10:GetLocal[0] i@16:I32x4ExtractLane R=ahaas@chromium.org, bbudge@chromium.org Review-Url: https://codereview.chromium.org/2307733002 Cr-Commit-Position: refs/heads/master@{#39142}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…//codereview.chromium.org/2310863002/ ) Reason for revert: Fails compilation: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang Original issue's description: > [gn] Switch win clang bot to gn > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588 > Cr-Commit-Position: refs/heads/master@{#39156} TBR=jochen@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2311853002 Cr-Commit-Position: refs/heads/master@{#39158}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…review.chromium.org/2301803003/ ) Reason for revert: Performance regressions: crbug.com/644087 Clusterfuzz: crbug.com/644074 We'll reland all regexp changes at once when the port is complete and at least performance-neutral, since the partial port requires slow workarounds. Original issue's description: > [regexp] Remove dead code > > Remove dead code, and drop the legacy RegExp.prototype.exec implementation (the > only differences are TO_BOOLEAN on global and sticky). > > BUG=v8:5339 > > Committed: https://crrev.com/1cb2a70cb5baa7545fdf9cc4e035a6d45cb189fd > Cr-Commit-Position: refs/heads/master@{#39121} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2310903002 Cr-Commit-Position: refs/heads/master@{#39165}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…//codereview.chromium.org/2311853002/ ) Reason for revert: Trying reland with plugin switched off. Original issue's description: > Revert of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2310863002/ ) > > Reason for revert: > Fails compilation: > https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang > > Original issue's description: > > [gn] Switch win clang bot to gn > > > > BUG=chromium:474921 > > NOTRY=true > > > > Committed: https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588 > > Cr-Commit-Position: refs/heads/master@{#39156} > > TBR=jochen@chromium.org,vogelheim@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:474921 > > Committed: https://crrev.com/49e13ea6eab4158915a75b95ccc9f01892924d9e > Cr-Commit-Position: refs/heads/master@{#39158} TBR=jochen@chromium.org,vogelheim@chromium.org NOTRY=true BUG=chromium:474921,chromium:644096 Review-Url: https://codereview.chromium.org/2312093002 Cr-Commit-Position: refs/heads/master@{#39201}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…atchset #1 id:1 of https://codereview.chromium.org/2298613003/ ) Reason for revert: Re-enable to get new data after recent changes. Original issue's description: > Remove --ignition-staging to --ignition-osr implication. > > Ignition OSR to turbofan seems to cause instruction selector crashes > (where instructions selector gets simplified operators, probably > because we break the effect chain somehow). > > BUG=chromium:641893 > > Committed: https://crrev.com/26df3e230ebd8c7d1cd95ea54155959eee7cb830 > Cr-Commit-Position: refs/heads/master@{#39045} TBR=bmeurer@chromium.org,jarin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:641893 Review-Url: https://codereview.chromium.org/2318943002 Cr-Commit-Position: refs/heads/master@{#39231}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…al memory. (patchset #1 id:1 of https://codereview.chromium.org/2329993002/ ) Reason for revert: Regressions in telemetry benchmarks: crbug.com/646819. Original issue's description: > [heap] Decouple old generation allocation limit from external memory. > > We check for external memory limit in Heap::ReportExternalMemoryPressure. > > BUG=chromium:616434 > > Committed: https://crrev.com/672d079ccba686019fa1457c83b42c2e692ef88b > Cr-Commit-Position: refs/heads/master@{#39374} TBR=hpayer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:616434 Review-Url: https://codereview.chromium.org/2339033005 Cr-Commit-Position: refs/heads/master@{#39442}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…all stats. (patchset #1 id:1 of https://codereview.chromium.org/2342643004/ ) Reason for revert: Revert because this breaks V8's roll into Chromium. ASAN complains about memory accesses in a particular unit test. Borked roll CL: https://codereview.chromium.org/2348833002/ Reproduce breakage with: 1, args.gn: v8_deprecation_warnings = true use_goma = true is_asan = true 2, ninja -C out/... content_browsertests 3, out/.../content_browsertests --gtest_filter=V8SamplingProfilerTest.* Original issue's description: > [Tracing] Remove unnecessary memory allocation in runtime call stats. > > Previously we didn't implement TRACE_STR_COPY when we write trace events to > file, which causes us to allocate a growing independent memory chunk for dumped > runtime call stats table. Since we now have a fully functional TRACE_STR_COPY, > this memory allocation can be avoided, this patch removes it. > > BUG=v8:5089 > > Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039 > Cr-Commit-Position: refs/heads/master@{#39462} TBR=cbruni@chromium.org,fmeawad@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Review-Url: https://codereview.chromium.org/2349593004 Cr-Commit-Position: refs/heads/master@{#39475}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…dereview.chromium.org/2354473002/ ) Reason for revert: Relanding with faster-running test Original issue's description: > Revert of Fix async/await memory leak (patchset #5 id:80001 of https://codereview.chromium.org/2334323006/ ) > > Reason for revert: > newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop > > Original issue's description: > > Fix async/await memory leak > > > > This patch closes a memory leak in async/await where the desugaring > > was creating a situation analagous to that described in v8:5002. > > Intermediate Promises were being kept alive, so a long-running loop > > would cause linear memory usage on the heap. This patch returns > > undefined to the 'then' callback passed into PerformPromiseThen > > in order to avoid this hazard. Test expectations are fixed to remove > > expecting extraneous events which occurred on Promises that are > > now not given unnecessarily complex resolution paths before being > > thrown away. > > > > BUG=v8:5390 > > > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > > Cr-Commit-Position: refs/heads/master@{#39479} > > TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org > NOTRY=true > BUG=v8:5390 > > Committed: https://crrev.com/196db1999da130019bbf8e3bd65977f840e8afaf > Cr-Commit-Position: refs/heads/master@{#39493} TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=v8:5390 Review-Url: https://codereview.chromium.org/2348403002 Cr-Commit-Position: refs/heads/master@{#39508}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…://codereview.chromium.org/2348403002/ ) Reason for revert: Still causes issues on bot (sometimes!) Original issue's description: > Reland of Fix async/await memory leak (patchset #1 id:1 of https://codereview.chromium.org/2354473002/ ) > > Reason for revert: > Relanding with faster-running test > > Original issue's description: > > Revert of Fix async/await memory leak (patchset #5 id:80001 of https://codereview.chromium.org/2334323006/ ) > > > > Reason for revert: > > newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop > > > > Original issue's description: > > > Fix async/await memory leak > > > > > > This patch closes a memory leak in async/await where the desugaring > > > was creating a situation analagous to that described in v8:5002. > > > Intermediate Promises were being kept alive, so a long-running loop > > > would cause linear memory usage on the heap. This patch returns > > > undefined to the 'then' callback passed into PerformPromiseThen > > > in order to avoid this hazard. Test expectations are fixed to remove > > > expecting extraneous events which occurred on Promises that are > > > now not given unnecessarily complex resolution paths before being > > > thrown away. > > > > > > BUG=v8:5390 > > > > > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > > > Cr-Commit-Position: refs/heads/master@{#39479} > > > > TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org > > NOTRY=true > > BUG=v8:5390 > > > > Committed: https://crrev.com/196db1999da130019bbf8e3bd65977f840e8afaf > > Cr-Commit-Position: refs/heads/master@{#39493} > > TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > BUG=v8:5390 > > Committed: https://crrev.com/e51482f01f26e0013e6377e85c4d2c41900e403c > Cr-Commit-Position: refs/heads/master@{#39508} TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5390 Review-Url: https://codereview.chromium.org/2348403003 Cr-Commit-Position: refs/heads/master@{#39512}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…(patchset #1 id:1 of https://codereview.chromium.org/2352573002/ ) Reason for revert: Real fix landed by now. Original issue's description: > [cq] Temporarily make failing chromium trybot experimental > > BUG=chromium:648153 > NOTRY=true > NOPRESUBMIT=true > TBR=emso@chromium.org > > Committed: https://crrev.com/bb6fa481b6e8e643cb86d66cfa5b8bb35d1dd320 > Cr-Commit-Position: refs/heads/master@{#39494} TBR=emso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648153 Review-Url: https://codereview.chromium.org/2353713002 Cr-Commit-Position: refs/heads/master@{#39516}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
… overflows. (patchset #1 id:1 of https://codereview.chromium.org/2348293002/ ) Reason for revert: Mean https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10910 Original issue's description: > [crankshaft] Protect against deopt loops from string length overflows. > > Crankshaft just unconditionally deoptimizes the code when the length of > a string addition result would overflow. In order to protect against > deopt loops we insert a global protector cell. > > We will use the same mechanism for inlining certain string additions > into TurboFan as well, and protecting against overflow (we will also > extend this to deal with String.prototype.concat and friends once we > get there). > > BUG=v8:5404 > R=jarin@chromium.org,hpayer@chromium.org > > Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71 > Cr-Commit-Position: refs/heads/master@{#39511} TBR=hpayer@chromium.org,jarin@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5404 Review-Url: https://codereview.chromium.org/2357433002 Cr-Commit-Position: refs/heads/master@{#39518}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…dereview.chromium.org/2348403003/ ) This patch closes a memory leak in async/await where the desugaring was creating a situation analagous to that described in v8:5002. Intermediate Promises were being kept alive, so a long-running loop would cause linear memory usage on the heap. This patch returns undefined to the 'then' callback passed into PerformPromiseThen in order to avoid this hazard. Test expectations are fixed to remove expecting extraneous events which occurred on Promises that are now not given unnecessarily complex resolution paths before being thrown away. This patch is a reland; originally, tests which exercised the memory exhaustion were checked in. Although it's possible to find good parameters for running such tests locally, it is difficult to automate the tests between the rock of timeouts and the hard place of too-small heaps causing memory exhaustion in some modes even when there is no leak. BUG=v8:5390 Review-Url: https://codereview.chromium.org/2352933002 Cr-Commit-Position: refs/heads/master@{#39520}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…omium.org/2360463002/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/3144 Original issue's description: > Update V8 DEPS. > > Rolling v8/base/trace_event/common to 199985e01e17b5a4888f83648b7cc119779e9245 > > Rolling v8/build to 4803815de7294778a1496c4e7f3e84ee48e243ef > > Rolling v8/buildtools to 57649e5e2001ba1f5e5d45f5a838c616ea0e9cb9 > > Rolling v8/tools/clang to cca919b21f2436ba1585f7e9de2702ba64fbd8bf > > TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org > > Committed: https://crrev.com/0ed1254d8103b40d5880601bf73b6c56e4d5716d > Cr-Commit-Position: refs/heads/master@{#39570} TBR=hablich@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2351943005 Cr-Commit-Position: refs/heads/master@{#39578}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
id:20001 of https://codereview.chromium.org/2363513003/ ) Reason for revert: race suspect: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11893 Original issue's description: > [fullcodegen] Refactor code that calls store ICs. > > Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load > slot according to store IC calling convention (StoreDescriptor). > > BUG=v8:5407 > > Committed: https://crrev.com/12918397b4af7b2bede8b29e1e9b1940d5d5ad3b > Cr-Commit-Position: refs/heads/master@{#39679} TBR=mvstanton@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5407 Review-Url: https://codereview.chromium.org/2363123002 Cr-Commit-Position: refs/heads/master@{#39682}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
id:1 of https://codereview.chromium.org/2363123002/ ) Reason for revert: Didn't help Original issue's description: > Revert of [fullcodegen] Refactor code that calls store ICs. (patchset #1 id:20001 of https://codereview.chromium.org/2363513003/ ) > > Reason for revert: > race suspect: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11893 > > Original issue's description: > > [fullcodegen] Refactor code that calls store ICs. > > > > Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load > > slot according to store IC calling convention (StoreDescriptor). > > > > BUG=v8:5407 > > > > Committed: https://crrev.com/12918397b4af7b2bede8b29e1e9b1940d5d5ad3b > > Cr-Commit-Position: refs/heads/master@{#39679} > > TBR=mvstanton@chromium.org,ishell@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5407 > > Committed: https://crrev.com/51fa56d1b8e9e320f7442682415e9df50ab19591 > Cr-Commit-Position: refs/heads/master@{#39682} TBR=mvstanton@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5407 Review-Url: https://codereview.chromium.org/2361393005 Cr-Commit-Position: refs/heads/master@{#39683}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…w.chromium.org/2364963003/ ) Reason for revert: Fixed underlying cause of TSAN issue; trying again while watching the bots. Original issue's description: > Revert of Ship async functions (patchset #2 id:20001 of https://codereview.chromium.org/2356943002/ ) > > Reason for revert: > Triggers TSAN errors on Linux64: > > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11901 > > Original issue's description: > > Ship async functions > > > > Intent to ship discussion: > > https://groups.google.com/forum/#!topic/v8-users/gwpcEIrgIZY > > > > BUG=v8:4483 > > > > Committed: https://crrev.com/9f7540a0ec6333e7c71615609fe29274d9b7a4c5 > > Cr-Commit-Position: refs/heads/master@{#39697} > > TBR=caitp@igalia.com,littledan@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4483 > > Committed: https://crrev.com/a4354b6c15fd9dbde2677efdf81fbc99ff0cf3e0 > Cr-Commit-Position: refs/heads/master@{#39699} TBR=caitp@igalia.com,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4483 Review-Url: https://codereview.chromium.org/2363093003 Cr-Commit-Position: refs/heads/master@{#39702}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…w.chromium.org/2363093003/ ) Reason for revert: TSAN failures still happening; need to investigate more. Original issue's description: > Reland of Ship async functions (patchset #1 id:1 of https://codereview.chromium.org/2364963003/ ) > > Reason for revert: > Fixed underlying cause of TSAN issue; trying again while watching the bots. > > Original issue's description: > > Revert of Ship async functions (patchset #2 id:20001 of https://codereview.chromium.org/2356943002/ ) > > > > Reason for revert: > > Triggers TSAN errors on Linux64: > > > > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11901 > > > > Original issue's description: > > > Ship async functions > > > > > > Intent to ship discussion: > > > https://groups.google.com/forum/#!topic/v8-users/gwpcEIrgIZY > > > > > > BUG=v8:4483 > > > > > > Committed: https://crrev.com/9f7540a0ec6333e7c71615609fe29274d9b7a4c5 > > > Cr-Commit-Position: refs/heads/master@{#39697} > > > > TBR=caitp@igalia.com,littledan@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=v8:4483 > > > > Committed: https://crrev.com/a4354b6c15fd9dbde2677efdf81fbc99ff0cf3e0 > > Cr-Commit-Position: refs/heads/master@{#39699} > > TBR=caitp@igalia.com,adamk@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4483 > > Committed: https://crrev.com/97cdf9f978e971df8a463fef7525bb942d305796 > Cr-Commit-Position: refs/heads/master@{#39702} TBR=caitp@igalia.com,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4483 Review-Url: https://codereview.chromium.org/2365113003 Cr-Commit-Position: refs/heads/master@{#39703}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…w.chromium.org/2364963003/ ) Fixed another TSAN issue in https://codereview.chromium.org/2365123002 TBR=caitp@igalia.com,adamk@chromium.org BUG=v8:4483 Review-Url: https://codereview.chromium.org/2367203002 Cr-Commit-Position: refs/heads/master@{#39708}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…g dangling references. (patchset #1 id:1 of https://codereview.chromium.org/2368253002/ ) Reason for revert: Needed for https://codereview.chromium.org/2373443003/ Original issue's description: > VariableProxy: when cloning, don't even think about creating dangling references. > > The code path for cloning resolved VariableProxys (into a different > Zone) was never hit, but if it was, it would create a dangling > reference, since the Variable would stay in the original Zone. > > Kudos to verwaest@ for finding this! > > R=verwaest@chromium.org > BUG= > > Committed: https://crrev.com/fd429bdb9e70cb8c4f8a4bbef0806e008c60440c > Cr-Commit-Position: refs/heads/master@{#39723} TBR=verwaest@chromium.org,marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2368303002 Cr-Commit-Position: refs/heads/master@{#39726}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…g dangling references. (patchset #1 id:1 of https://codereview.chromium.org/2368303002/ ) Reason for revert: wrong CL Original issue's description: > Revert of VariableProxy: when cloning, don't even think about creating dangling references. (patchset #1 id:1 of https://codereview.chromium.org/2368253002/ ) > > Reason for revert: > Needed for https://codereview.chromium.org/2373443003/ > > Original issue's description: > > VariableProxy: when cloning, don't even think about creating dangling references. > > > > The code path for cloning resolved VariableProxys (into a different > > Zone) was never hit, but if it was, it would create a dangling > > reference, since the Variable would stay in the original Zone. > > > > Kudos to verwaest@ for finding this! > > > > R=verwaest@chromium.org > > BUG= > > > > Committed: https://crrev.com/fd429bdb9e70cb8c4f8a4bbef0806e008c60440c > > Cr-Commit-Position: refs/heads/master@{#39723} > > TBR=verwaest@chromium.org,marja@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/8edf2905693a2b486a97a0547ec53bb552f7db15 > Cr-Commit-Position: refs/heads/master@{#39726} TBR=verwaest@chromium.org,marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2366373002 Cr-Commit-Position: refs/heads/master@{#39728}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…ps://codereview.chromium.org/2373443003/ ) Reason for revert: Stability thief found, relanding speculative reverts. Original issue's description: > Revert of Preparse inner functions (new try) (patchset v8#21 id:420001 of https://codereview.chromium.org/2352593002/ ) > > Reason for revert: > We currently have some stability issues on Canary. Let's reland this after we verified that we "fixed" Canary again. > > Original issue's description: > > Preparse inner functions (new try) > > > > This is an overly pessimistic approach where PreParser only keeps > > track of unresolved variables, but doesn't declare anything. This > > will result in context-allocating variables in the outer function > > unnecessarily, if the variable names clash with variable names > > used by the inner function (even if the variables are not the > > same). However, we have been unable to prove that this approach > > wouldn't be good enough for the practical purposes. > > > > Fixes after the previous try ( https://codereview.chromium.org/2322243002/ ): > > Keep the context-allocation decision stable when compiling fully eagerly. > > > > Tests which exercise this functionality: > > mjsunit/fixed-context-shapes-when-recompiling.js > > > > Design document (chromium): > > > > https://docs.google.com/a/chromium.org/document/d/1rRv5JJZ0JpOZAZN2CSUwZPFJiBAdRnTiSYhazseNHFg/edit?usp=sharing > > > > BUG= > > > > Committed: https://crrev.com/7c73cf32c60484cdf37c84f1d61b4640e87068d7 > > Cr-Commit-Position: refs/heads/master@{#39719} > > TBR=verwaest@chromium.org,adamk@chromium.org,marja@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/1e6296b2a7cfc307fd9e722e619f42965da4a267 > Cr-Commit-Position: refs/heads/master@{#39730} TBR=verwaest@chromium.org,adamk@chromium.org,marja@chromium.org,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2377513006 Cr-Commit-Position: refs/heads/master@{#39755}
targos
pushed a commit
that referenced
this issue
Sep 30, 2016
…ng of the function was started (patchset #1 id:1 of https://codereview.chromium.org/2365393002/ ) Reason for revert: Stability thief found, relanding speculative reverts. Original issue's description: > Revert of Preparse functions in the scope that was created when parsing of the function was started (patchset #2 id:20001 of https://codereview.chromium.org/2370713003/ ) > > Reason for revert: > Needed for https://codereview.chromium.org/2373443003/ > > Original issue's description: > > Preparse functions in the scope that was created when parsing of the function was started > > > > This reduces the number of scopes for lazily parsed top-level functions from 3 to 1 > > > > BUG=v8:5209 > > > > Committed: https://crrev.com/9618d095903c604a032b33792c068f4a6169503c > > Cr-Commit-Position: refs/heads/master@{#39725} > > TBR=marja@chromium.org,verwaest@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5209 > > Committed: https://crrev.com/0cef7100da0b609403c9026fb7307192a898a390 > Cr-Commit-Position: refs/heads/master@{#39729} TBR=marja@chromium.org,verwaest@chromium.org,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5209 Review-Url: https://codereview.chromium.org/2377593002 Cr-Commit-Position: refs/heads/master@{#39756}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
Revision: 8f22fce BUG=chromium:662674 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=yangguo@chromium.org Review URL: https://codereview.chromium.org/2498533002 . Cr-Commit-Position: refs/branch-heads/5.5@{v8#38} Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
Merged: Add test for making private symbols non-enumerable Revision: 942604d Merged: Make private symbols non-enumerable Revision: 135b9f9 BUG=chromium:664411,chromium:664411 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=cbruni@chromium.org Review URL: https://codereview.chromium.org/2498973002 . Cr-Commit-Position: refs/branch-heads/5.5@{v8#40} Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
Revision: 87332fd BUG=chromium:663402 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=cbruni@chromium.org Review URL: https://codereview.chromium.org/2500843002 . Cr-Commit-Position: refs/branch-heads/5.5@{v8#42} Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
Revision: b4ccb16 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2500803002 Cr-Commit-Position: refs/branch-heads/5.5@{v8#44} Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
Revision: c7ebb14 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bjaideep@ca.ibm.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2504483003 Cr-Commit-Position: refs/branch-heads/5.5@{v8#46} Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
…set #1 id:1 of https://codereview.chromium.org/2491773006/ ) Reason for revert: Revert because it depends on https://codereview.chromium.org/2478323002/ which has been reverted. Original issue's description: > [compiler] Enable shared function marking by default > > BUG=v8:5512 TBR=bmeurer@chromium.org,leszeks@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5512 Review-Url: https://codereview.chromium.org/2491643006 Cr-Commit-Position: refs/heads/master@{#40926}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
…:1 of https://codereview.chromium.org/2486283003/ ) Reason for revert: Breaks CQ trybots now, i.e. https://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/24703/steps/compile%20with%20ninja/logs/stdio Original issue's description: > MIPS: Optimize load/store with large offset > > Currently, we are using the following sequence for load/store with large offset (offset > 16b): > > lui at, 0x1234 > ori at, at, 0x5678 > add at, s0, at > lw a0, 0(at) > > This sequence can be optimized in the following way: > > lui at, 0x1234 > add at, s0, at > lw a0, 0x5678(at) > > BUG= TBR=ivica.bogosavljevic@imgtec.com,miran.karic@imgtec.com,v8-mips-ports@googlegroups.com,dusan.simicic@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2500863003 Cr-Commit-Position: refs/heads/master@{#40959}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
…tchset #1 id:1 of https://codereview.chromium.org/2495243002/ ) Reason for revert: Seems to break GC stress. Original issue's description: > [turbofan] Fix deoptimization of boolean bit constants. > > BUG=chromium:664490 TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:664490 Review-Url: https://codereview.chromium.org/2502613002 Cr-Commit-Position: refs/heads/master@{#40961}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
…ps://codereview.chromium.org/2491373004/ ) Reason for revert: It's probably needed after all but we're lacking tests. Original issue's description: > [ast] Simplify FetchFreeVariables. > > This CL removes the ParseInfo argument from FetchFreeVariables, since it seems > to have become unnecessary. > > R=verwaest@chromium.org > BUG= TBR=verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2495293002 Cr-Commit-Position: refs/heads/master@{#40964}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
…tchset #1 id:1 of https://codereview.chromium.org/2495243002) This reverts commit 1c9528c. BUG=chromium:664490 Review-Url: https://codereview.chromium.org/2503763003 Cr-Commit-Position: refs/heads/master@{#40994}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
…https://codereview.chromium.org/2505853003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11394 Original issue's description: > Refactor SharedFunctionInfo::IsBuiltin. > > This method is a slight misnomer. What we actually want to know is > whether the function was defined in a user-provided script. > > Also remove redundant Script::hide_source flag. > > R=bmeurer@chromium.org, ulan@chromium.org TBR=bmeurer@chromium.org,ulan@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2512463002 Cr-Commit-Position: refs/heads/master@{#41050}
targos
pushed a commit
that referenced
this issue
Nov 17, 2016
…nk_rel. (patchset #1 id:1 of https://codereview.chromium.org/2475563002/ ) Reason for revert: Submitting this before more capacity was added to linux_trusty_blink_rel caused that builder to get too busy (http://crbug.com/665246); should be able to reland after http://crbug.com/665917 is fixed. Original issue's description: > Update usage of linux blink try bot to use linux_trusty_blink_rel. > > Reason: We're planning to drop support for Linux Precise for layout tests. > > BUG=chromium:660580 > NOTRY=true TBR=machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:660580 NOTRY=true Review-Url: https://codereview.chromium.org/2507853002 Cr-Commit-Position: refs/heads/master@{#41052}
targos
pushed a commit
that referenced
this issue
Nov 19, 2016
…nk_rel. (patchset #1 id:1 of https://codereview.chromium.org/2507853002/ ) Reason for revert: linux_trusty_blink_rel is now working, with more capacity Original issue's description: > Revert of Update usage of linux blink try bot to use linux_trusty_blink_rel. (patchset #1 id:1 of https://codereview.chromium.org/2475563002/ ) > > Reason for revert: > Submitting this before more capacity was added to linux_trusty_blink_rel caused that builder to get too busy (http://crbug.com/665246); should be able to reland after http://crbug.com/665917 is fixed. > > Original issue's description: > > Update usage of linux blink try bot to use linux_trusty_blink_rel. > > > > Reason: We're planning to drop support for Linux Precise for layout tests. > > > > BUG=chromium:660580 > > NOTRY=true > > TBR=machenbach@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:660580 > NOTRY=true TBR=machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:660580 Review-Url: https://codereview.chromium.org/2505403002 Cr-Commit-Position: refs/heads/master@{#41090}
targos
pushed a commit
that referenced
this issue
Nov 19, 2016
… with oddballs. (patchset #1 id:1 of https://codereview.chromium.org/2513903002/ ) Reason for revert: Seems to break layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11452 Original issue's description: > [interpreter] Properly collect rhs feedback for comparisons with oddballs. > > Ignition skipped collecting NumberOrOddball feedback if the right hand > side of a relational comparison is undefined, thus leading to a > deoptimization loop, because it reported Number feedback to TurboFan. > > This was caught on 3d-raytrace test of SunSpider. > > R=rmcilroy@chromium.org > > Committed: https://crrev.com/d240ffec32ae034e50c006f7d5715171b32bbbc4 > Cr-Commit-Position: refs/heads/master@{#41094} TBR=rmcilroy@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2511243004 Cr-Commit-Position: refs/heads/master@{#41100}
targos
pushed a commit
that referenced
this issue
Nov 19, 2016
Revision: 1900760 BUG=chromium:626986 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/2517543002 . Cr-Commit-Position: refs/branch-heads/5.5@{v8#48} Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
targos
pushed a commit
that referenced
this issue
Nov 19, 2016
targos
pushed a commit
that referenced
this issue
Nov 19, 2016
targos
pushed a commit
that referenced
this issue
Nov 19, 2016
targos
pushed a commit
that referenced
this issue
Nov 19, 2016
BUG=chromium:318206 TBR=vogelheim@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2517523002 Cr-Commit-Position: refs/branch-heads/5.6@{#3} Cr-Branched-From: bdd3886-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f659-refs/heads/master@{#41014}
targos
pushed a commit
that referenced
this issue
Nov 19, 2016
Thank you @jbergstroem for taking care of this, it is very much appreciated! |
targos
added a commit
to targos/node
that referenced
this issue
Feb 7, 2017
Refs: nodejs/v8#1 PR-URL: nodejs#11029 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this issue
Feb 14, 2017
Refs: nodejs/v8#1 PR-URL: nodejs#11029 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It seems that
std::to_string
does not exist on this platform ?I tried to change the
std
flag tognu++11
but get the same error:Build: https://ci.nodejs.org/job/node-test-commit-smartos/4536/nodes=smartos14-32/console
/cc @nodejs/platform-solaris
The text was updated successfully, but these errors were encountered: