Apply ow power selection at the end of the write slot while irqs are masked #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but I haven't/can't test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1797.
devbranch rather than formaster.The strong output driver is activated at the end of the last write slot for power=1 case while interrupts are still masked. This ensures that TSPON(max) is not violated when an interrupt is pending.
I couldn't stimulate the suspected failure case due to the tight timing requirements (have an interrupt triggered at exactly the right time slot). But tests with 2 DS18B20s in powered and parasite mode on the bus didn't reveal any regressions at least.