User middleware #660
User middleware #660
Conversation
bergie
force-pushed
the
user_middleware
branch
from
316928d to
9a9903c
Compare
bergie
force-pushed
the
user_middleware
branch
from
95ef89a to
cc6d2d6
Compare
… NoFlo components
| async: true | ||
| , (data, groups, out, callback) -> | ||
| actionParts = c.params.action.split ':' | ||
| setTimeout -> |
There was a problem hiding this comment.
Workaround for bracket forwarding bug in WirePattern. Would be fixed by going 0.8 process API
| c.inPorts.add 'action', | ||
| datatype: 'string' | ||
| required: true | ||
| control: true |
There was a problem hiding this comment.
Not really needed, was going to do it with process API first, but decided to stick to WirePattern until 0.8 stable is out
| async: true | ||
| forwardGroups: false | ||
| , (data, groups, out, callback) -> | ||
| # This will in effect cause a NoFlo network stop as the app |
There was a problem hiding this comment.
Can't we use some single-page-app magic to avoid redirect reloading page? For future..
There was a problem hiding this comment.
We're using this to redirect to GitHub, too. The URL query cleanup we do post-login can be done down the line with pushState
| <script src="CreateProject.js"></script> | ||
| <script src="EditGraph.js"></script> | ||
| <script src="DeleteGraph.js"></script> | ||
| <script src="EndToEndInitialization.js"></script> |
There was a problem hiding this comment.
Can we use a directory for these tests? spec/endtoend/Login.coffee or spec/acceptance/Login.coffee, or spec/ui/...
| "fbp": "~1.5.0", | ||
| "fbp-spec": "~0.1.15", | ||
| "flowhub-registry": "^0.1.0", | ||
| "font-awesome": "^4.6.3", | ||
| "indexeddbshim": "^2.2.1", | ||
| "jshint": "^2.9.2", | ||
| "microflo": "~0.3.43", | ||
| "noflo": "~0.7.9", | ||
| "noflo": "^0.7.9", |
There was a problem hiding this comment.
On the 0.x series these are effectively the same in semver. Why the change?
There was a problem hiding this comment.
I think side effect of trying 0.8 beta and then going back to 0.7 to get only one NoFlo into the bundle (as opposed to N pulled in via individual modules)
| @@ -46,5 +46,3 @@ exports.getComponent = -> | |||
| return callback err if err | |||
| out.send valid | |||
| do callback | |||
|
|
|||
| c | |||
There was a problem hiding this comment.
Bug? Or does WirePattern return the component?
There was a problem hiding this comment.
WirePattern returns the component, just like most of the component methods
| it 'should pass it out as-is', (done) -> | ||
| action = 'runtime:connect' | ||
| payload = | ||
| hello: 'world' |
There was a problem hiding this comment.
Eh, what is this case for? Does not seem useful. Please use test-data which is representative for real usage.
There was a problem hiding this comment.
I wanted a test of a passed packet. The contents don't really matter as long as:
- the action is one that the middleware isn't supposed to handle
- we verify the packet gets passed through without manipulation (strict equality check)
| else | ||
| baseDir = 'noflo-ui' | ||
|
|
||
| describe 'User Middleware', -> |
| actionIn.port = 'action' | ||
| ### | ||
| c.network.on 'begingroup', (data) -> | ||
| console.log " < #{data.id}" |
There was a problem hiding this comment.
No flowtraces on bare (non-runtime) NoFlo networks I think? Would be super useful
| token = 'niov2o3wnnv4ioufuhh92348fh42q9' | ||
| xhr = sinon.fakeServer.create() | ||
| afterEach -> | ||
| xhr.restore() |
There was a problem hiding this comment.
Would prefer to use a name for the mock which singifies testing more than xhr. Like mock or mockAuth
| message: 'Bad Credentials' | ||
| do xhr.respond | ||
| do xhr.respond | ||
| describe 'without user and with valid grant code in URL', -> |
There was a problem hiding this comment.
Should this be with user instead of without?
|
No unused components to delete after this? |
|
I think the |
|
@bergie I don't understand how this is different from the existing "Store" code... I don't see any removed code from UI layer? |
|
No code removal from UI yet, though now that we have all of this in place removing the user API calls in |
|
@bergie ok looks good to me. Merge at will |
Moves user data handling from mixture of storage and UI to a Redux-style middleware graph:
Middleware components receive an action, and can either pass the action onwards, or capture it and emit their own actions instead.
This way for instance a
user:loginaction gets caught by the UserMiddleware graph, which then performs the OAuth dance, and down the line emits eitheruser:info(for successful login) oruser:error(for failed login).