Refresh user information at start-up #670
Conversation
bergie
changed the title
| if (!this.user) { | ||
| return; | ||
| } | ||
| if (!this.user.plan || this.user.plan.type === 'free') { |
There was a problem hiding this comment.
Why more logic in Polymer elements? We should be removing logic, not adding.
There was a problem hiding this comment.
This is UI-side logic so I found this to be the right place for it.
There was a problem hiding this comment.
Storing askForScope in the widget introduces (more) statefulness. Is there at least a less stateful way to represent this transformation of user info to these scopes?
And is this the scopes we have asked for, or will ask for? The naming is not clear.
There was a problem hiding this comment.
These are scopes we offer to the user as options to allow. The "grant access to X" buttons are populated from this.
| @@ -74,90 +52,6 @@ | |||
| detached: function () { | |||
| document.getElementById('container').classList.remove('blur'); | |||
| }, | |||
| checkFlowhubUser: function (callback) { | |||
There was a problem hiding this comment.
Good, less logic in view elements.
|
|
||
| unless navigator.onLine | ||
| # When offline we can't refresh | ||
| out.pass.send data |
There was a problem hiding this comment.
I'd consider sending the not-logged-in and not-online cases to different ports. That way the semantics of the component is visible from outside, in the graph.
There was a problem hiding this comment.
This component doesn't really care whether logged in or not. The actual thing the component does should be pretty well reflected in the ports:
- User information was fine as-is (whether logged in or not)
- User information was invalid (non-working OAuth token etc)
- User information was updated from IdP
Follow-up to #660. Will fix #632
Also adds a much clearer way for users to grant the app access to their GitHub repositories: