This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Remove timing printlns #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
@kevaundray I am for removing these as they clutter the output for |
Sounds good -- I think if we want to do debugging, then they can be added back manually or we can add a compile flag in the future |
kevaundray
approved these changes
Feb 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the printouts in the form
Total Proving time (Rust + Static Lib) : 40469750ns ~ 0secondswhich are largely unnecessary and notably clog the output when using the newnargo testcommand.Users interested in proving and verification time can test it themselves via
time,hyperfine, or other more featureful command line utilities.