-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nargo): Add nargo test
command to run all unit tests
#728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
reviewed
Feb 1, 2023
kevaundray
reviewed
Feb 1, 2023
kevaundray
reviewed
Feb 1, 2023
kevaundray
reviewed
Feb 1, 2023
5 tasks
Cannot add |
kevaundray
reviewed
Feb 2, 2023
vezenovm
reviewed
Feb 2, 2023
vezenovm
requested changes
Feb 2, 2023
This PR is ready for review again |
vezenovm
reviewed
Feb 3, 2023
vezenovm
approved these changes
Feb 3, 2023
TomAFrench
added a commit
to TomAFrench/noir
that referenced
this pull request
Feb 3, 2023
* master: feat(nargo): Add `nargo test` command to run all unit tests (noir-lang#728) chore(ci): Apply `doc needed` label automatically on PRs (noir-lang#733) chore(ci): Remove failing bors workflow (noir-lang#744) feat(ci): Add workflow to validate PR title (noir-lang#730) feat(docs): Introduce Conventional Commits & release process docs (noir-lang#717)
TomAFrench
added a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #610
Description
Adds the
nargo test
command to collect all functions with the new#[test]
attribute and prove each of them, notifying the user if any test fails.Summary of changes
nargo test
command#[test]
attribute#[test]
functions afterward and run the backend on each.nargo test
accepts an optionalpattern
argument to only run tests with names containing the given pattern.Dependency additions / changes
aztec_backend
should be updated from this PR: Remove timing printlns acvm-backend-barretenberg#49 to clean up testing output. Otherwise the timing information is printed in between each running test.Checklist
cargo fmt
with default settings.Additional context
Tasks yet to be done: (all completed):
#[test]
attribute have no parameterscatch_unwind
to stop any panics that may happen when running a test - we cannot do this actually since ourDriver
type makes use of internal mutability.Example output running 2 tests (1 passing, 1 failing) (after aztec_backend update now):