chore: allow common ascii punctuation in attributes (#3733)

# Description

spotted an issue with punctuation inside a `#[test(should_fail_with =
"")]` block ([comment on original
issue](#3372 (comment)))

## Problem\*

Resolves #3372 (an extension of this original issue)

## Summary\*

I built off of the original work done over here #3374 but simplified
things down to just cover all common punctuation

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>

compiler/noirc_frontend/src/lexer/lexer.rs

@@ -633,15 +633,18 @@ mod tests {
     }
 
     #[test]
-    fn test_attribute_with_apostrophe() {
-        let input = r#"#[test(should_fail_with = "the eagle's feathers")]"#;
+    fn test_attribute_with_common_punctuation() {
+        let input =
+            r#"#[test(should_fail_with = "stmt. q? exclaim! & symbols, 1% shouldn't fail")]"#;
         let mut lexer = Lexer::new(input);
 
         let token = lexer.next_token().unwrap().token().clone();
         assert_eq!(
             token,
             Token::Attribute(Attribute::Function(FunctionAttribute::Test(
-                TestScope::ShouldFailWith { reason: "the eagle's feathers".to_owned().into() }
+                TestScope::ShouldFailWith {
+                    reason: "stmt. q? exclaim! & symbols, 1% shouldn't fail".to_owned().into()
+                }
             )))
         );
     }

compiler/noirc_frontend/src/lexer/token.rs

@@ -468,13 +468,8 @@ impl Attribute {
                 .all(|ch| {
                     ch.is_ascii_alphabetic()
                         || ch.is_numeric()
-                        || ch == '_'
-                        || ch == '('
-                        || ch == ')'
-                        || ch == '='
-                        || ch == '"'
+                        || ch.is_ascii_punctuation()
                         || ch == ' '
-                        || ch == '\''
                 })
                 .then_some(());