chore: Allow apostrophes in attributes #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
reviewed
Oct 31, 2023
jfecher
changed the title
jfecher
reviewed
Oct 31, 2023
jfecher
reviewed
Nov 1, 2023
added 2 commits
November 2, 2023 05:22
ghost
requested a review
from 
TomAFrench
pushed a commit
that referenced
this pull request
Nov 14, 2023
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2023
# Description spotted an issue with punctuation inside a `#[test(should_fail_with = "")]` block ([comment on original issue](#3372 (comment))) ## Problem\* Resolves #3372 (an extension of this original issue) ## Summary\* I built off of the original work done over here #3374 but simplified things down to just cover all common punctuation ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
#3372
Documentation
Check one:
PR Checklist
cargo fmton default settings.