Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): allow multiple attributes #2537

Merged
merged 9 commits into from
Sep 11, 2023
Merged

feat(parser): allow multiple attributes #2537

merged 9 commits into from
Sep 11, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Sep 2, 2023 •
edited
Loading

Description

As discussed with Kev; this splits attributes into two sections

  • Primary Attributes
    • These are attributes which are builtin and alter the function kind
    • There can only be one primary attribute, the parser will error if it receives more than one
  • Secondary Attributes
    • These are attributes of which there can be multiple, as they do not change the function type
    • These would include the tags used by the aztec library, or the #[deprecated] keyword

@Maddiaa0 Maddiaa0 force-pushed the md/multiple-attributes branch from d6af9c7 to f8c2c2b Compare September 2, 2023 16:49
@Maddiaa0 Maddiaa0 requested a review from kevaundray September 2, 2023 16:50
@Maddiaa0 Maddiaa0 marked this pull request as ready for review September 11, 2023 12:32
@Maddiaa0 Maddiaa0 requested a review from kevaundray September 11, 2023 12:41
@kevaundray kevaundray added this pull request to the merge queue Sep 11, 2023
Merged via the queue into master with commit 7cdff2e Sep 11, 2023
@kevaundray kevaundray deleted the md/multiple-attributes branch September 11, 2023 14:50
@kevaundray kevaundray mentioned this pull request Sep 11, 2023
Merged
TomAFrench added a commit that referenced this pull request Sep 11, 2023
@TomAFrench
Merge branch 'master' into tf/noir-wasm-dedupe
dc6d022 
* master:
  chore(ci): reenable CI for `noir_wasm` (#2636)
  fix: avoid overflows in integer division (#2180)
  chore(ci): Nightly Integration testing  (#2596)
  feat(parser): allow multiple attributes (#2537)
  feat(nargo): Allow installing custom backends from the CLI (#2632)
TomAFrench added a commit that referenced this pull request Sep 11, 2023
@TomAFrench
Merge branch 'master' into tf/explicit-package-type-handling
c017d1f 
* master:
  chore: Move tooling related items into their own directory (#2644)
  chore: add `CompilationResult` helper type (#2639)
  fix: initialise arrays returned by brillig (#2048)
  chore: clippy fix (#2631)
  fix(wasm): Remove stacker from dependencies (#2637)
  chore(ci): reenable CI for `noir_wasm` (#2636)
  fix: avoid overflows in integer division (#2180)
  chore(ci): Nightly Integration testing  (#2596)
  feat(parser): allow multiple attributes (#2537)
  feat(nargo): Allow installing custom backends from the CLI (#2632)
  chore(ci): enforce clippy and `cargo fmt` in CI (#2628)
@TomAFrench TomAFrench mentioned this pull request Sep 12, 2023
Merged
5 tasks
@Savio-Sou
Copy link
Collaborator

This lives under the aztec feature flag (i.e. no Noir docs needed) right?

@Maddiaa0
Copy link
Member Author

Nope, its just vanilla noir, although there are no user facing features that are outside of the aztec flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maddiaa0 @Savio-Sou @kevaundray