fix(wasm): Remove stacker from dependencies #2637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Up until this change, we've been unable to build
noir_wasm
on Mac. When trying to compile, we'd get this message:While the error was "Section too large", I felt like it might be a red herring since the
libpsm_s.a
was mentioned in the warning. In the psm docs, it claims:I did some digging and found we were only getting the dependency due to default features of chumsky (the
spill-stack
feature), so I turned off the feature and tried for compiling to wasm—and it worked!I'm not exactly sure why
noir_wasm
compiles on Linux but not Mac with this dependency, but seems that it wouldn't be doing anything in the wasm context, so I'm also guessing we don't rely on it.@jfecher Do you know if Noir actively depend upon this
spill-stack
feature through thestacker
dependency of chumsky?Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.