chore(ci): Nightly Integration testing #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
TomAFrench
reviewed
Sep 8, 2023
TomAFrench
reviewed
Sep 8, 2023
TomAFrench
reviewed
Sep 8, 2023
|
This also fails silently. Can you add some form of alerting? |
kevaundray
reviewed
Sep 11, 2023
kevaundray
reviewed
Sep 11, 2023
crates/integration-tests/test/integration/browser/compile_prove_verify.test.ts
Outdated
Show resolved
Hide resolved
|
Some form of alerting is required if we're running this on a schedule. We're not going to manually check this every morning so things will silently fail for a long time until we notice it. We had the same issue with nightly builds in |
TomAFrench
reviewed
Sep 11, 2023
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
reviewed
Sep 11, 2023
TomAFrench
reviewed
Sep 11, 2023
|
Should be good to go after final 2 nits |
TomAFrench
changed the title
TomAFrench
reviewed
Sep 11, 2023
crates/integration-tests/test/integration/browser/compile_prove_verify.test.ts
Outdated
Show resolved
Hide resolved
…e_verify.test.ts Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
previously approved these changes
Sep 11, 2023
TomAFrench
reviewed
Sep 11, 2023
crates/integration-tests/test/integration/browser/compile_prove_verify.test.ts
Outdated
Show resolved
Hide resolved
TomAFrench
approved these changes
Sep 11, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 11, 2023
* master: chore: Move tooling related items into their own directory (#2644) chore: add `CompilationResult` helper type (#2639) fix: initialise arrays returned by brillig (#2048) chore: clippy fix (#2631) fix(wasm): Remove stacker from dependencies (#2637) chore(ci): reenable CI for `noir_wasm` (#2636) fix: avoid overflows in integer division (#2180) chore(ci): Nightly Integration testing (#2596) feat(parser): allow multiple attributes (#2537) feat(nargo): Allow installing custom backends from the CLI (#2632) chore(ci): enforce clippy and `cargo fmt` in CI (#2628)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: Headless Browser testing #2610
Should pass integration tests on nightly schedule.
This PR is +366 lines, the additional lines are from the yarn.lock file.
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.