-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nargo): add nargo execute
command
#725
Conversation
f116df0
to
42a649c
Compare
* master: chore: readability improvements (#726)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me from my perspective. I'd like another approval before merging though.
In relation to #728, I think it would be faster for that PR but I also think for that PR I can change it to stop right after SSA or ACIR without proving at all since all failing constraints should be caught during SSA as everything would be constant due to there being no inputs.
Cheers, this should probably wait until #731 is in at least. |
* master: feat(noir)!: Returned values are no longer required by the prover (#731)
this is an artifact of me deduping public inputs in the wrong place
return values are now never provided rather than optional
Related issue(s)
Resolves #626
Description
Summary of changes
This PR adds the
nargo execute
command which is responsible for loading prover inputs and solving the witness for the circuit. This is essentially the Rust equivalent ofsolveAcirPartialWitness
from the noir.js hackmd.Benefits being:
Verifier.toml
.I've named thislet's leave it as execute as it's more understandable to non-ZK devs.nargo execute
as I initially thought of it as a command to "execute the noir program and print its return value" but it may be worth renaming to something more "witness-y"Dependency additions / changes
N/A
Test additions / changes
N/A
Checklist
cargo fmt
with default settings.Additional context