Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssa): Add intial control flow graph #1200

Merged
merged 22 commits into from
Apr 25, 2023
Merged

Conversation

joss-aztec
Copy link
Contributor

@joss-aztec joss-aztec commented Apr 21, 2023

Related issue(s)

Resolves #1117

Description

Summary of changes

Added ControlFlowGraph for computing the cfg for a given function.

Dependency additions / changes

Test additions / changes

Unit tests for checking correct cfg computation.

Checklist

  • I have tested the changes locally.
  • [ x I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Let me know when this is ready for review

@joss-aztec joss-aztec marked this pull request as ready for review April 24, 2023 20:57
@joss-aztec joss-aztec requested a review from kevaundray April 24, 2023 20:57
@kevaundray kevaundray changed the title chore(ssa): new cfg chore(ssa): Add intial control flow graph Apr 24, 2023
jfecher
jfecher previously approved these changes Apr 24, 2023
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can add the test comments in another PR if needed

@jfecher jfecher added this pull request to the merge queue Apr 25, 2023
Merged via the queue into master with commit f3fe121 Apr 25, 2023
@jfecher jfecher deleted the joss/ssa_refactor_cfg branch April 25, 2023 14:16
TomAFrench added a commit that referenced this pull request Apr 29, 2023
* master: (223 commits)
  chore(noir): Release 0.5.0 (#1202)
  chore(ci): Utilize new workflow to build binaries (#1250)
  chore(ssa refactor): Fix loading from mutable parameters (#1248)
  fix(wasm): add std after dependencies (#1245)
  chore(ssa refactor): Fix no returns & duplicate main (#1243)
  chore(ssa refactor): Implement intrinsics (#1241)
  chore(ssa refactor): Implement first-class functions (#1238)
  chore: address clippy warnings (#1239)
  chore(ssa refactor): Implement function calls (#1235)
  chore(ssa refactor): Implement mutable and immutable variables (#1234)
  chore(ssa refactor): Fix recursive printing of blocks (#1230)
  feat(noir): added assert keyword (#1227)
  chore(ssa refactor): Implement ssa-gen for indexing, cast, constrain, if, unary (#1225)
  feat(noir): added `distinct` keyword (#1219)
  chore(nargo): update panic message to suggest searching for similar issues (#1224)
  chore(ssa refactor): Update how instruction result types are retrieved (#1222)
  chore(ssa refactor): Implement ssa-gen for binary, block, tuple, extract-tuple-field, and semi expressions (#1217)
  chore: add RUST_BACKTRACE environment variable to nix config (#1216)
  chore(ssa): Add intial control flow graph  (#1200)
  chore(ssa refactor): Handle codegen for literals (#1209)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add control flow graph (CFG)
2 participants