Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa refactor): Implement ssa-gen for binary, block, tuple, extract-tuple-field, and semi expressions #1217

Merged
merged 2 commits into from
Apr 25, 2023
Merged

chore(ssa refactor): Implement ssa-gen for binary, block, tuple, extract-tuple-field, and semi expressions #1217

merged 2 commits into from
Apr 25, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Apr 25, 2023

Related issue(s)

Resolves #

Description

Summary of changes

The majority of changes added here are for binary operations. The rest are comparatively simple.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@jfecher jfecher requested a review from kevaundray April 25, 2023 16:42
@kevaundray kevaundray enabled auto-merge April 25, 2023 17:59
@kevaundray kevaundray added this pull request to the merge queue Apr 25, 2023
Merged via the queue into master with commit 27b8bf8 Apr 25, 2023
@kevaundray kevaundray deleted the jf/ssa-binary branch April 25, 2023 18:34
TomAFrench added a commit that referenced this pull request Apr 29, 2023
@TomAFrench
Merge branch 'master' into mikeneuder-20230212-1
e90e915 
* master: (223 commits)
  chore(noir): Release 0.5.0 (#1202)
  chore(ci): Utilize new workflow to build binaries (#1250)
  chore(ssa refactor): Fix loading from mutable parameters (#1248)
  fix(wasm): add std after dependencies (#1245)
  chore(ssa refactor): Fix no returns & duplicate main (#1243)
  chore(ssa refactor): Implement intrinsics (#1241)
  chore(ssa refactor): Implement first-class functions (#1238)
  chore: address clippy warnings (#1239)
  chore(ssa refactor): Implement function calls (#1235)
  chore(ssa refactor): Implement mutable and immutable variables (#1234)
  chore(ssa refactor): Fix recursive printing of blocks (#1230)
  feat(noir): added assert keyword (#1227)
  chore(ssa refactor): Implement ssa-gen for indexing, cast, constrain, if, unary (#1225)
  feat(noir): added `distinct` keyword (#1219)
  chore(nargo): update panic message to suggest searching for similar issues (#1224)
  chore(ssa refactor): Update how instruction result types are retrieved (#1222)
  chore(ssa refactor): Implement ssa-gen for binary, block, tuple, extract-tuple-field, and semi expressions (#1217)
  chore: add RUST_BACKTRACE environment variable to nix config (#1216)
  chore(ssa): Add intial control flow graph  (#1200)
  chore(ssa refactor): Handle codegen for literals (#1209)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfecher @kevaundray