Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): Update GitHub Feature Request Template #1369

Merged
merged 1 commit into from
May 22, 2023

Conversation

Savio-Sou
Copy link
Collaborator

Description

Summary of changes

Updating the feature request template:

  • Add a "Would you like to submit a PR for this Issue?" section to encourage external contributions
  • Remove project board checkbox
  • Minor word & formatting changes

Try it out: https://github.com/noir-lang-test/noir/issues/new?assignees=&labels=enhancement&projects=&template=feature_request.yml

Demo Issue: noir-lang-test#14

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

Once this is merged, I'll create a PR to update the template in noir-lang/.github accordingly.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reflect these changes over to https://github.com/noir-lang/.github/blob/main/.github/ISSUE_TEMPLATE/feature_request.yml?plain=1 so we get them in the other repositories as well?

@Savio-Sou
Copy link
Collaborator Author

Yup will update all 3 templates there once #1368 #1369 #1370 are merged.

@TomAFrench TomAFrench added this pull request to the merge queue May 22, 2023
Merged via the queue into master with commit a69e2c0 May 22, 2023
@TomAFrench TomAFrench deleted the ss-feature-request-template branch May 22, 2023 17:04
TomAFrench added a commit that referenced this pull request May 24, 2023
* master:
  chore(ssa refactor): Add loop unrolling pass (#1364)
  chore: Add terms added in ssa refactor to `cspell` (#1385)
  chore(ssa refactor): Optimize constant `jmpif`s into `jmp`s (#1374)
  feat: Allow warnings by default (#1383)
  chore(github): Update GitHub Pull Request Template (#1370)
  chore(github): Update GitHub Bug Report Template (#1368)
  chore(ssa refactor): Update mem2reg pass to work with multiple functions and blocks (#1375)
  chore(ssa refactor): Add pass to simplify the control flow graph (#1373)
  chore(github): Update GitHub Feature Request Template (#1369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants