Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add terms added in ssa refactor to cspell #1385

Merged
merged 1 commit into from
May 23, 2023
Merged

chore: Add terms added in ssa refactor to cspell #1385

merged 1 commit into from
May 23, 2023

Conversation

joss-aztec
Copy link
Contributor

Description

Problem*

Resolves https://github.com/noir-lang/noir/pull/1374/files#r1201735511

Summary*

This PR adds jmp, jmpif, jmps, jmpifs and cranelift to cspell

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@joss-aztec joss-aztec mentioned this pull request May 23, 2023
Merged
6 tasks
@joss-aztec joss-aztec requested a review from TomAFrench May 23, 2023 09:05
@TomAFrench TomAFrench enabled auto-merge May 23, 2023 09:12
@TomAFrench TomAFrench disabled auto-merge May 23, 2023 09:14
@TomAFrench TomAFrench changed the title chore: cspell additions chore: Add terms added in ssa refactor to cspell May 23, 2023
@TomAFrench TomAFrench enabled auto-merge May 23, 2023 09:14
@TomAFrench TomAFrench added this pull request to the merge queue May 23, 2023
Merged via the queue into master with commit dfb24ba May 23, 2023
@TomAFrench TomAFrench deleted the joss/cspell-jmp branch May 23, 2023 11:07
TomAFrench added a commit that referenced this pull request May 24, 2023
@TomAFrench
Merge branch 'master' into phated/acvm-0.12.0
09db55c 
* master:
  chore(ssa refactor): Add loop unrolling pass (#1364)
  chore: Add terms added in ssa refactor to `cspell` (#1385)
  chore(ssa refactor): Optimize constant `jmpif`s into `jmp`s (#1374)
  feat: Allow warnings by default (#1383)
  chore(github): Update GitHub Pull Request Template (#1370)
  chore(github): Update GitHub Bug Report Template (#1368)
  chore(ssa refactor): Update mem2reg pass to work with multiple functions and blocks (#1375)
  chore(ssa refactor): Add pass to simplify the control flow graph (#1373)
  chore(github): Update GitHub Feature Request Template (#1369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joss-aztec @TomAFrench