Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): deny wildcard dependencies #2702

Merged
merged 3 commits into from
Sep 14, 2023
Merged

chore(ci): deny wildcard dependencies #2702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93b5ef3
chore(ci): turn on errors for wildcard dependencies
TomAFrench Sep 14, 2023
96527c9
chore: remove `getrandom` dependency
TomAFrench Sep 14, 2023
dd24a79
chore: reduce wildcards to a warning
TomAFrench Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions compiler/wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,5 @@ gloo-utils = { version = "0.1", features = ["serde"] }
log = "0.4.17"
wasm-logger = "0.2.0"

# This is an unused dependency, we are adding it
# so that we can enable the js feature in getrandom.
getrandom = { version = "*", features = ["js"] }

[build-dependencies]
build-data = "0.1.3"
7 changes: 0 additions & 7 deletions compiler/wasm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,6 @@ use serde::{Deserialize, Serialize};
use std::str::FromStr;
use wasm_bindgen::prelude::*;

// This dependency is not used. We import it
// to bypass the `unused_crate_dependencies` lint.
//
// It is being imported as we get errors regarding the
// js feature not being enabled.
use getrandom as _;

mod circuit;
mod compile;

Expand Down
4 changes: 2 additions & 2 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ notice = "warn"
# Lint level for when multiple versions of the same crate are detected
multiple-versions = "warn"
# Lint level for when a crate version requirement is `*`
wildcards = "allow"
wildcards = "warn"
highlight = "all"
# List of crates to deny
deny = [
Expand Down Expand Up @@ -97,4 +97,4 @@ unknown-registry = "warn"
unknown-git = "deny"
allow-git = [
"https://github.com/jfecher/chumsky"
]
]
4 changes: 0 additions & 4 deletions tooling/noirc_abi_wasm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ gloo-utils = { version = "0.1", features = ["serde"] }

js-sys = "0.3.62"

# This is an unused dependency, we are adding it
# so that we can enable the js feature in getrandom.
getrandom = { version = "*", features = ["js"] }

[build-dependencies]
build-data = "0.1.3"

Expand Down
3 changes: 0 additions & 3 deletions tooling/noirc_abi_wasm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
#![warn(unreachable_pub)]
#![warn(clippy::semicolon_if_nothing_returned)]

// See Cargo.toml for explanation.
use getrandom as _;

use acvm::acir::native_types::WitnessMap;
use iter_extended::try_btree_map;
use noirc_abi::{errors::InputParserError, input_parser::InputValue, Abi, MAIN_RETURN_NAME};
Expand Down