chore: add init method to Noir class for web #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Koby Hall <102518238+kobyhallx@users.noreply.github.com>
Co-authored-by: Koby Hall <102518238+kobyhallx@users.noreply.github.com>
Co-authored-by: Koby Hall <102518238+kobyhallx@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
kevaundray
commented
Oct 1, 2023
|
Reliant on #2902 |
5 tasks
signorecello
previously requested changes
Oct 1, 2023
TomAFrench
reviewed
Oct 2, 2023
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
reviewed
Oct 2, 2023
TomAFrench
previously approved these changes
Oct 2, 2023
TomAFrench
reviewed
Oct 2, 2023
TomAFrench
approved these changes
Oct 2, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 3, 2023
* master: (53 commits) feat: Nargo test runtime callstacks and assert messages without string matching (#2953) chore: Release Noir(0.16.0) (#2908) chore: run smart contract verification integration tests inside hardhat (#2957) chore: fix publishing workflows (#2926) chore: restructure integration tests (#2954) fix: Improve error message when multiplying unit values (#2950) chore: Perform lazy initialization inside `noir_js` (#2951) chore: Make one input public in simple assertion program (#2949) chore: use new JS packages in integration tests (#2938) fix(println): Enable printing of arrays/strings >2 in fmt strings (#2947) feat(ssa): Multiple slice mergers (#2753) fix: fix should_fail_with (#2940) feat: Oracle mocker for nargo test (#2928) chore: add linting to new packages (#2937) feat: Dynamic indexing of non-homogenous slices (#2883) chore: Fix barretenberg noir typescript wrapper (#2922) chore(ci): Rename Noir.js test job (#2932) feat!: Maintain shape of foreign call arguments (#2935) chore: add init method to Noir class for web (#2920) chore: bump `reqwest` to 0.11.20 (#2931) ...
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Co-authored-by: Koby Hall <102518238+kobyhallx@users.noreply.github.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Tom French <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are required to initialize the web assembly modules when in the web for our dependencies.
This adds a method for this on the Noir class
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.