Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure integration tests #2954

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR reorganizes the integration tests to a structure to be ready to integrate hardhat. I've taken the opportunity to break out helpful functions to utils files.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kobyhallx October 3, 2023 10:01
@TomAFrench
Copy link
Member Author

Ah, whoops forgot to update the circuit paths. One sec

kobyhallx
kobyhallx previously approved these changes Oct 3, 2023
@TomAFrench TomAFrench enabled auto-merge October 3, 2023 10:59
@TomAFrench TomAFrench added this pull request to the merge queue Oct 3, 2023
@TomAFrench TomAFrench removed this pull request from the merge queue due to a manual request Oct 3, 2023
kobyhallx
kobyhallx previously approved these changes Oct 3, 2023
@TomAFrench TomAFrench enabled auto-merge October 3, 2023 11:22
@TomAFrench TomAFrench added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 3, 2023
* master:
  fix: Improve error message when multiplying unit values (#2950)
  chore: Perform lazy initialization inside `noir_js` (#2951)
@TomAFrench TomAFrench added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Oct 3, 2023
Merged via the queue into master with commit 2960483 Oct 3, 2023
26 checks passed
@TomAFrench TomAFrench deleted the tf/reorganize-integration-tests branch October 3, 2023 14:05
TomAFrench added a commit that referenced this pull request Oct 3, 2023
* master: (53 commits)
  feat: Nargo test runtime callstacks and assert messages without string matching (#2953)
  chore: Release Noir(0.16.0) (#2908)
  chore: run smart contract verification integration tests inside hardhat (#2957)
  chore: fix publishing workflows (#2926)
  chore: restructure integration tests (#2954)
  fix: Improve error message when multiplying unit values (#2950)
  chore: Perform lazy initialization inside `noir_js` (#2951)
  chore: Make one input public in simple assertion program (#2949)
  chore: use new JS packages in integration tests (#2938)
  fix(println): Enable printing of arrays/strings >2 in fmt strings  (#2947)
  feat(ssa): Multiple slice mergers (#2753)
  fix: fix should_fail_with (#2940)
  feat: Oracle mocker for nargo test (#2928)
  chore: add linting to new packages (#2937)
  feat: Dynamic indexing of non-homogenous slices (#2883)
  chore: Fix barretenberg noir typescript wrapper (#2922)
  chore(ci): Rename Noir.js test job (#2932)
  feat!: Maintain shape of foreign call arguments (#2935)
  chore: add init method to Noir class for web (#2920)
  chore: bump `reqwest` to 0.11.20 (#2931)
  ...
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants