Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Noir debugger (brillig) #3404

Closed
wants to merge 31 commits into from

Conversation

dmvict
Copy link
Contributor

@dmvict dmvict commented Nov 2, 2023

Description

The separate binary app to debug noir binary applications using brillig bytecode.

Problem*

It's new feature.
The related issue is #3094

Summary*

Extends Noir toolings by the new utility. Allows to compile brillig bytecode for a noir binary module and debug it.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link

socket-security bot commented Nov 15, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/glob 8.1.0 None +2 3.8 MB types
esbuild 0.18.20 environment +22 207 MB evanw
@types/mocha 10.0.4 None +0 95.4 kB types
@types/vscode 1.84.1 None +0 626 kB types
@typescript-eslint/eslint-plugin 5.62.0 None +17 48.7 MB jameshenry
@typescript-eslint/parser 5.62.0 None +10 45.5 MB jameshenry
@types/node 20.2.5 None +0 3.78 MB types
@vscode/test-electron 2.3.6 eval, filesystem, shell, environment +5 939 kB vscode-bot
eslint 8.53.0 None +3 3.14 MB eslintbot
typescript 5.2.2 None +0 40.6 MB typescript-bot

@dmvict dmvict marked this pull request as ready for review November 22, 2023 09:17
@dmvict dmvict mentioned this pull request Nov 22, 2023
13 tasks
@dmvict
Copy link
Contributor Author

dmvict commented Nov 22, 2023

I made no changes in the main parts of code but I'll check the failed workflows.
Please, see updates in #3094

license.workspace = true

[dependencies]
acvm = { git = "https://github.com/dmvict/noir", rev = "db36e6d66b9fadfbf27f7d2852de806095f7c77e" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to use a fork?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to use a fork?

Hello @kevaundray

Yes, the pr still need the fork. I described the changes in the first post in the issue #3094.
Here is the code that allows to compile the brillig bytecode.
I think we should continue discussion about integration of this changes in the other issue/pr.
Once the changes will be properly integrated into repo I'll be able to remove the fork from dependencies.

@TomAFrench TomAFrench closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants